Ticket #3291 (closed: fixed)
Improve code reuse in VatesAPITest
| Reported by: | Janik Zikovsky | Owned by: | Janik Zikovsky |
|---|---|---|---|
| Priority: | minor | Milestone: | Iteration 30 |
| Component: | VATES | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
... by moving some of the shared mock objects to one file.
Change History
comment:1 Changed 9 years ago by Janik Zikovsky
- Status changed from new to accepted
- Summary changed from Improve code reuse it VatesAPITest to Improve code reuse in VatesAPITest
comment:2 Changed 9 years ago by Janik Zikovsky
- Status changed from accepted to verify
- Resolution set to fixed
(In [12935]) Corrected Q in MakeDiffractionEventWorkspace (to not have 2*pi and to be q = ki-kf, it was kf-ki). Added a Paraview plugin, PeaksReader, to load .peaks file to visualize them. Needed to add a link to the Crystal library. Refs #3232. Added a vtkPeakMarkerFactory to render single-crystal peaks (as points). Not totally finished. Refs #3232. Made vtkDataSetFactory::initialise() take a Workspace_sptr instead of a IMDWorkspace_sptr. This allowed the visualization of a PeaksWorkspace. Still needs tests. Made the MultiDimensionalDbPresenter::getMesh() method return a vtkDataSet* (instead of vtkUnstructuredGrid*) to be more general. Attempted to speed up/parallelize vtkThresholdingHexahedronFactory without much improvement so far. Refs #3271. Made a MockObjects.hh file to reuse mock objects code in VatesAPITest. Fixes #3291. Sped up setUp of EventListTestPerformance; also InstrumentRayTracerTestPerformance. Refs #3217.
comment:3 Changed 9 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:4 Changed 9 years ago by Michael Reuter
- Status changed from verifying to closed
I did manage to find the creation of the mock object header and that looked OK. There seems to be a lot of other changes that don't necessarily belong to this ticket. It' hard to see the forest through the trees in this case. The original intent of the ticket has been satisfied, but the spirit has been a violated a bit.
