Ticket #3321 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Deprecate DiffractionFocussing (version 1)

Reported by: Janik Zikovsky Owned by: Russell Taylor
Priority: minor Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

... so that we don't need to maintain it.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [13051]) Fixes #3321: deprecated DiffractionFocussing1. Fix tests in release version (refs #3203). Fix a few warnings Refs #3302.

comment:3 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:4 Changed 9 years ago by Vickie Lynch

Version 1 still is available as an option in MantidPlot. It starts some version automatically when I select this. Which version?

DiffractionFocussing-[Error] DiffractionFocussing is deprecated (on 2011-07-08). Use DiffractionFocussing instead. DiffractionFocussing-[Notice] DiffractionFocussing started

comment:5 Changed 9 years ago by Janik Zikovsky

Looks like it starts version 2? Maybe the algorithm selection tree is not working right?

comment:6 Changed 9 years ago by Vickie Lynch

Take DiffractionFocussing.cpp and DiffractionFocussing.h out of CMakeLists.txt and we can close this ticket. I just tried it and only version 2 is in tree.

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to verify

In [14784]:

Fixes #3321: Just remove DiffractionFocussing version 1.

comment:8 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to verifying

comment:9 Changed 9 years ago by Russell Taylor

  • Tester changed from Vickie Lynch to Russell Taylor

comment:10 Changed 9 years ago by Russell Taylor

  • Status changed from verifying to reopened
  • Resolution fixed deleted
  • Tester Russell Taylor deleted

comment:11 Changed 9 years ago by Russell Taylor

  • Status changed from reopened to accepted
  • Owner changed from Janik Zikovsky to Russell Taylor

comment:12 Changed 9 years ago by Russell Taylor

In [14788]:

Restore DiffractionFocussing1 pending a search for the underlying problem. Re #3321.

comment:13 Changed 9 years ago by Russell Taylor

In [14791]:

Restore DiffractionFocussing v1 code to it's state prior to [13051], but marked as deprecated. Re #3321.

comment:14 Changed 9 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

This should be fine now. The reason version 2 was showing up when v1 was selected was because, at the original deprecation, v1 was simply made to inherit from v2 - so was therefore identical!

comment:15 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:16 Changed 9 years ago by Vickie Lynch

  • Status changed from verifying to closed

Both version 1 and 2 give same results for a Workspace2D with version 2 a factor of 2 faster.

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4168

Note: See TracTickets for help on using tickets.