Ticket #3752 (closed: wontfix)

Opened 9 years ago

Last modified 5 years ago

Making Google Mock mandatory in CMake

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Should we ?

Change History

comment:1 Changed 9 years ago by Russell Taylor

If not mandatory, use the approach taken in #3717 for tcmalloc of forcing people to change a CMake variable if they want to build without it, rather than just carrying on with only a warning message that most people won't notice.

comment:2 Changed 9 years ago by Nick Draper

  • Owner set to Anyone
  • Status changed from new to assigned

I agree, we can add this as a developer dependency

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:7 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:8 Changed 8 years ago by Stuart Campbell

  • Owner changed from Anyone to Stuart Campbell
  • Status changed from assigned to accepted
  • Milestone changed from Release 2.5 to Release 2.4

comment:9 Changed 8 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to wontfix

Since we build gmock as part of building the tests, I'm not sure this ticket is valid any more.

comment:10 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:11 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

I agree.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4599

Note: See TracTickets for help on using tickets.