Ticket #4055 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Expand GroupWorkspaces to allow grouping of table workspaces

Reported by: Anders Markvardsen Owned by: Robert Whitley
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

1) Modify the algorithm GroupWorkspaces to allow this 2) Do a test. Group say a TableWorkspace and a standard MatrixWorkspace. Try to run this grouped workspace through a number of Mantid algorithms such as Minus and CropWorkspace. Likely outcome is that error messages will be displayed which needs to be dealt with. Initially the way do deal with these will be to modify how algorithms handle groups. E.g. Algorithm.cpp has a method: bool Algorithm::processGroups(). Modify this method to ignore TableWorkspaces and log this.

Change History

comment:1 Changed 9 years ago by Robert Whitley

I took the code out of GroupWorkspaces.cpp that checks to see if all workspaces are the same.

The code from ticket #3790 ran without a problem and grouped all workspaces together. I then tried to run the newly formed workspace group through a series of algorithms.

The current implementation of Mantid does not allow for the 'mixed' workspace group to be picked up by an algorithm.

comment:2 Changed 9 years ago by Robert Whitley

Refs #3790. Fitted workspaces within the muon interface are grouped.

Includes code for #4055. Expand the group workspaces allowing for mixed workspaces with table workspaces. The algorithms work with the newly formed groups but will ignore the table workspaces if they come across one.

https://github.com/mantidproject/mantid/commit/a42ba792541f578e9099a4e0a8724cc0b1d84caf

comment:3 Changed 9 years ago by Robert Whitley

Refs #4055. Add test for grouping TableWorkspaces.

Changeset: a2a92a19b50965a8796f3b76e3ed306f41507e1d

comment:4 Changed 9 years ago by Robert Whitley

  • Status changed from new to accepted

comment:5 Changed 9 years ago by Robert Whitley

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 9 years ago by Robert Whitley

Refs #4055. Add test for grouping TableWorkspaces.

Changeset: a2a92a19b50965a8796f3b76e3ed306f41507e1d

comment:7 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:8 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to closed

These with mixture of tableworkspaces and matrixworkspaces

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4902

Note: See TracTickets for help on using tickets.