Fix SaveAscii when WriteXError is checked.

[Robert Whitley]

To replicate bug,

1) Load in the file MUSR00015194.nxs

2) Call the algorithm SaveAscii on either "MUSR00015194_1" or "MUSR00015194_2"(making sure WriteXError is checked).

If you save a file this way the following error will appear when you try to load it back into Mantid.

Invalid data format found in file "C:/Users/rqh12525/Desktop/asdgsg.dat" LoadAscii requires the number of columns to be an even multiple of either 2 or 3.Error in execution of algorithm LoadAscii: Invalid data format. Error in execution of algorithm Load: Invalid data format.

[Nick Draper]

Moved at end of release 2.1

[Nick Draper]

Moved at the end of release 2.2

[Nick Draper]

Moved to milestone 2.4

[Nick Draper]

Moved at the code freeze for release 2.4

[Nick Draper]

Moved to r2.6 at the end of r2.5

[Nick Draper]

Retested and found to work

[Mathieu Doucet]

I followed the steps outlined in the description and it did produce the error as described.

[Karl Palmen]

LoadAscii reckons the number of spectra and the type of errors included based only on the number of columns.

If there are 2 columns, then 1 spectrum with no errors.

Else if there are an odd number of columns, then the number of spectra is assumed to be half the number of columns ignoring the remainder and with Y-errors only.

Else if there are four columns, then 1 spectrum, with both X and Y errors.

There is no support for multiple spectra, except for spectra with Y errors only.

[Karl Palmen]

I have found that SaveAscii adds only one column of data for the X error, but one X error column header for each spectrum. If the data columns are correct (i.e. there should be just one X error column) a simple fix is in sight.

[Karl Palmen]

I'll fix for one column of X errors. If a workspace requires a column of X errors for each spectrum, it is really a ragged workspace and this is in the scope of ticket #3493.

[Karl Palmen]

The bare fix re #4464

Still to do: A check of constant number of columns in LoadAscii and Correct column headers and wiki in SaveAscii.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 2fc54a6c14ebd809ac721b98e60c8f9de09a8d0a

[Karl Palmen]

Tidied up LoadAscii.cpp checked its format checks re #4464

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b4e07838845b5346a21ead186c795dd796e5f3cd

[Karl Palmen]

I've found that LoadAsciiTest does not test for multispectra files. I'll add a test for two spectra without X errors (5 columns) and two spectra with X errors (6 columns). I can use data from the MUSR example mentioned.

[Karl Palmen]

SaveAsciiTest does not test the writeXError property.

[Karl Palmen]

Prepare LoadAsciiTest to handle more numbers of columns re #4464

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d4d6970ea8e55349c4bb8d2a934ea975937d1e7e

[Karl Palmen]

Skeleton extension of LoadAsciiTest re #4464

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0b0773a762a1f2241c424a6d77bdea49569959e2

[Karl Palmen]

Disable new unit tests re #4464

They don't work on is_imc_rhel6_develop and ornl_oxs10.6_develop. LoadAscii fails to read the test file on those systems.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 2036ef5829970fff902ab2fa8fd016897f0cdaf8

[Karl Palmen]

I've created ticket #7666, because I could not quickly get the unit tests I had added to work.

[Karl Palmen]

Write header for only one X error when needed re #4464

SaveAscii already writes just on X error. This change in the header makes it consistent.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a6896e8c60abbf9552d7cd384b78575a036de5e5

[Karl Palmen]

Update wiki re #4464

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 56410292e8215676fd5a73c025f037458bdcffa0

[Karl Palmen]

To test create a workspace like that got by loading the MUSR file mentioned in this ticket. Run SaveAscii on it for several spectra with and without the WriteXerror ticked.

Check that the resulting ascii files look OK, the first column is X and is followed by pairs of Y.. E.. columns and if WriteXerror has been selected there is a DX column at the end. Check that the number of columns matches the number of column headers.

Check that it loads OK with LoadAscii (or Load).

[Keith Brown]

#7732 is blocking this ticket as SaveAscii seems to be saving files wrongly, so this ticket can't be passed until that's fixed. Assuming that fixing this ticket didn't produce the error.

[Keith Brown]

Advised by nick that this is a failure case as if SaveASCII has been altered, LoadASCII needs equivalent changes made to it so that the saved file can be loaded.

#7732 isn't blocking any more as the error is totally separate.

[Karl Palmen]

This ticket has been superceded by #7732, which will amongst other things ensure Xerror works for multiple spectra.

[Keith Brown]

The ticket for sorting out the file format renders this ticket invalid so there's no need to fix this any more.

[Stuart Campbell]

This ticket has been transferred to github issue ​5311