Ticket #5532 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Stitch1D Adding Two MDWorkspaces

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By: #5541
Blocking: Tester: Martyn Gigg

Description

Stitch 2 MDWorkspaces together for ISIS reflectometry.

Workspaces are in Qz vs Qx with Qx integrated out. The intensity values are I/I0.

This is part of the solution to the overall 1D stitching required by Tim Charlton. Once we can combine 2 MDWorkspaces together, it should be easily possible to do this for many MDWorkspaces.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Owen Arnold

Preliminary version is probably best implemented as a Python Algorithm.

comment:3 Changed 8 years ago by Owen Arnold

refs #5532. Template for algorithm

Changeset: a22e4ad27ea1340f093e2ba9eb5f33118ed0c7f4

comment:4 Changed 8 years ago by Owen Arnold

refs #5532. Rename tests

Changeset: a947b645945a3c9ec4f3559064ee0ea993a649aa

comment:5 Changed 8 years ago by Owen Arnold

refs #5532. remove tests

Changeset: f381a87c60c3a4c4f05b1144748ebd6f4f1db0a3

comment:6 Changed 8 years ago by Owen Arnold

refs #5532. Extend tests and calculate scale factor

Changeset: d1959289fe40fee1eeac2492c3220b8f6b9fcc78

comment:7 Changed 8 years ago by Owen Arnold

  • Blocked By 5541 added

comment:8 Changed 8 years ago by Owen Arnold

refs #5532. Weighted Mean

Changeset: dc4a74b4aa1e4e984953f3a8c2caecfc25ed7749

comment:9 Changed 8 years ago by Owen Arnold

refs #5532. Add overlay_overlap

Changeset: 8524ccc4208665557ffaa205051b67b1561c1493

comment:10 Changed 8 years ago by Owen Arnold

refs #5532. Extend stitching testing

Changeset: 87247546161be0803e147b47a083edc848d16b23

comment:11 Changed 8 years ago by Owen Arnold

refs #5532. Manual scaling factor handled properly

Changeset: e4f8d0d8a8bd7df5fbe8a8c6dbad8ac655552dc3

comment:12 Changed 8 years ago by Owen Arnold

refs #5532 Scale WS2 by default

Changeset: 41b4cf064aa5bc25e15771514152ef3c6436b602

comment:13 Changed 8 years ago by Owen Arnold

refs #5532. A number of changes described below.

Firstly, I made it more robust to having either 1d or 2d md workspaces as inputs. This allows us to iterate over the algorithm in order to recursively combine many 1D segments.

I also fixed a bug in the calculation of the target index for the overlapping weighted-mean sections.

Tests have been extended to cover both of these.

The algorithm has been executed on Tims test data and seems close to the benchmark outputs. Changeset: 26fdc94eafef4fdf2a470e8768efbc853e46d777

comment:14 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: Check the code and unit tests. The outputs of the algorithm are close, but not exactly the same as those produced with the genie scripts. Although the stitched outputs do follow the correct trend, and the correct mantitudes are recorded. Tim Charlton, believes that this algorithm is working correctly, but we suffer in Mantid from our inability to perform proper efficiency corrections yet, which is producing slight perturbations in the results.

comment:15 Changed 8 years ago by Owen Arnold

refs #5532. Template for algorithm

Changeset: a22e4ad27ea1340f093e2ba9eb5f33118ed0c7f4

comment:16 Changed 8 years ago by Owen Arnold

refs #5532. Rename tests

Changeset: a947b645945a3c9ec4f3559064ee0ea993a649aa

comment:17 Changed 8 years ago by Owen Arnold

refs #5532. remove tests

Changeset: f381a87c60c3a4c4f05b1144748ebd6f4f1db0a3

comment:18 Changed 8 years ago by Owen Arnold

refs #5532. Extend tests and calculate scale factor

Changeset: d1959289fe40fee1eeac2492c3220b8f6b9fcc78

comment:19 Changed 8 years ago by Owen Arnold

refs #5532. Weighted Mean

Changeset: dc4a74b4aa1e4e984953f3a8c2caecfc25ed7749

comment:20 Changed 8 years ago by Owen Arnold

refs #5532. Add overlay_overlap

Changeset: 8524ccc4208665557ffaa205051b67b1561c1493

comment:21 Changed 8 years ago by Owen Arnold

refs #5532. Extend stitching testing

Changeset: 87247546161be0803e147b47a083edc848d16b23

comment:22 Changed 8 years ago by Owen Arnold

refs #5532. Manual scaling factor handled properly

Changeset: e4f8d0d8a8bd7df5fbe8a8c6dbad8ac655552dc3

comment:23 Changed 8 years ago by Owen Arnold

refs #5532 Scale WS2 by default

Changeset: 41b4cf064aa5bc25e15771514152ef3c6436b602

comment:24 Changed 8 years ago by Owen Arnold

refs #5532. A number of changes described below.

Firstly, I made it more robust to having either 1d or 2d md workspaces as inputs. This allows us to iterate over the algorithm in order to recursively combine many 1D segments.

I also fixed a bug in the calculation of the target index for the overlapping weighted-mean sections.

Tests have been extended to cover both of these.

The algorithm has been executed on Tims test data and seems close to the benchmark outputs. Changeset: 26fdc94eafef4fdf2a470e8768efbc853e46d777

comment:25 Changed 8 years ago by Owen Arnold

refs #5532. Wiki docs

Changeset: b176d690f4f78c44491d9402cbad8c841022698c

comment:26 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:27 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:28 Changed 8 years ago by Owen Arnold

refs #5532. Wiki docs

Changeset: b176d690f4f78c44491d9402cbad8c841022698c

comment:29 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6378

Note: See TracTickets for help on using tickets.