Inconsistant pathnames in Workspace History

[Anders Markvardsen]

On Windows 64:

1) Open MantidPlot

2) Load in this example HRP39182.raw. Followed by ConvertUnits to dSpacing and DiffractionFocussing using the GroupingFileName hrpd_new_072_01.cal

The Workspace generated from this is surprisingly:

###################################################################### #Python Script Generated by GeneratePythonScript Algorithm ###################################################################### Load(Filename='C:\Users\ajm64\Desktop\NOBUGS Workshop\HRP39182.RAW',OutputWorkspace='HRP39182',LoadMonitors=r'Exclude') ConvertUnits(InputWorkspace='HRP39182',OutputWorkspace='HRP39182',Target='dSpacing') DiffractionFocussing(InputWorkspace='HRP39182',OutputWorkspace='HRP39182',GroupingFileName=r'C:/Users/ajm64/Desktop/NOBUGS Workshop/hrpd_new_072_01.cal',PreserveEvents='0')

I.e. the use of r in front of pathnames is unusual:

• in Load it is 'C:\Users\ajm64\Desktop\NOBUGS Workshop\HRP39182.RAW' and hence the script will not work without prefixing with an r

• also in Load, for some reason has the parameter LoadMonitors=r'Exclude', i.e. with an r in front of 'Exclude', perhaps this r is meant to be in front of Filename path?

[Anders Markvardsen]

Hi Martyn, for info cc you on this ticket

[Nick Draper]

Moved to milestone 2.4

[Martyn Gigg]

Fix inconsistent path handling in WS history. Refs #5885

Load is now not a special case and any FileProperty/MultipleFileProperty value is prefixed with r to turn then into raw strings.

Changeset: 1a5cea610c4260f56f2e494dcd8ad8d22a13a01e

[Martyn Gigg]

Fix inconsistent path handling in WS history. Refs #5885

Load is now not a special case and any FileProperty/MultipleFileProperty value is prefixed with r to turn then into raw strings.

Changeset: 1a5cea610c4260f56f2e494dcd8ad8d22a13a01e

[Martyn Gigg]

Branch: feature/5885_history_bad_paths

Tester: Please test this on Windows as it is vital to check that the resultant script will actually work so it needs to use windows-style paths.

To test it is best to follow the procedure above and check that the generated script can be loaded.

[Martyn Gigg]

Fix inconsistent path handling in WS history. Refs #5885

Load is now not a special case and any FileProperty/MultipleFileProperty value is prefixed with r to turn then into raw strings.

Changeset: 1a5cea610c4260f56f2e494dcd8ad8d22a13a01e

[Nick Draper]

all files have r"..." and the script works fine, both to file and clipboard

[Russell Taylor]

Unfortunately, this has broken the SNSPowderRedux.SeriesAndConjoinFilesTest system test:

GeneratePythonScript-[Error] Error in execution of algorithm GeneratePythonScript:
GeneratePythonScript-[Error] Unknown property search object Precount

(SNSPowderReduction calls GeneratePythonScript and Precount is a property on LoadEventNexus)

It's already 5.30 here so I'm not sure that I can do anything about this. If I run GeneratePythonScript locally on a workspace from an event nexus file it only fails if Precount is set to True (which is not the default).

[Martyn Gigg]

Fix inconsistent path handling in WS history. Refs #5885

Load is now not a special case and any FileProperty/MultipleFileProperty value is prefixed with r to turn then into raw strings.

Changeset: 1a5cea610c4260f56f2e494dcd8ad8d22a13a01e

[Martyn Gigg]

Fix inconsistent path handling in WS history. Refs #5885

Load is now not a special case and any FileProperty/MultipleFileProperty value is prefixed with r to turn then into raw strings.

Changeset: 1a5cea610c4260f56f2e494dcd8ad8d22a13a01e

[Martyn Gigg]

Fix inconsistent path handling in WS history. Refs #5885

Load is now not a special case and any FileProperty/MultipleFileProperty value is prefixed with r to turn then into raw strings.

Changeset: 1a5cea610c4260f56f2e494dcd8ad8d22a13a01e

[Stuart Campbell]

This ticket has been transferred to github issue ​6731