Ticket #5913 (closed: wontfix)
Add mechanism to check Ui generated classes don't have the same name
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.6 |
| Component: | Framework | Keywords: | Maintenance |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Karl Palmen |
Description
It was recently discovered, [5911], that when generating classes with the Qt designer it is possible to have name clashes that are not picked up by the compiler. This can cause runtime failures when the incorrect classes are used within a custom dialog.
It should be possible to use CMake to generate an articifial cpp file that simply includes all of the ui_* headers to check whether it compiles. If not, there is a name clash and and something needs to be changed.
This would be better than discovering this at runtime.
Change History
comment:2 Changed 8 years ago by Nick Draper
- Owner set to Martyn Gigg
- Status changed from new to assigned
comment:4 Changed 8 years ago by Martyn Gigg
- Priority changed from major to blocker
- Milestone changed from Release 2.5 to Release 2.6
Moved to maintenance task for next release
comment:5 Changed 7 years ago by Nick Draper
- Priority changed from blocker to critical
- Keywords Maintenance added
comment:7 Changed 7 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to wontfix
After a little play with trying the solution mentioned above this is going to be more work than I thought for not much gain at all. I think my time can be better spent elsewhere as this has only ever happened once.
comment:8 Changed 7 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:9 Changed 7 years ago by Karl Palmen
- Status changed from verifying to closed
I'm satisfied that this could be too difficult to be worthwhile.
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6759
Moved to milestone 2.4