Ticket #593 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

Improve algorithm property feedback

Reported by: Nick Draper Owned by: Steve Williams
Priority: major Milestone: Iteration 18
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

Extension on #409 to improve the user interface aspects of this.

Change History

comment:1 Changed 11 years ago by Steve Williams

(In [2483]) There are changes to WorkspacePropertys that affect PropertyManager. In all cases Property.setValue() now returns a string containing any validation errors. This is a change to the WorkspacePropertys that sometimes ignored errors. There are descriptions for some propertys in MantidPlot available as a tooltip re #593 and re #410

comment:2 Changed 11 years ago by Steve Williams

  • Status changed from new to assigned

comment:3 Changed 11 years ago by Steve Williams

(In [2491]) There are still some problems from the change to property::isDefault() and PropertyManager::setValue. This check in repairs the tests that were failing. There is documentation for more properties of algorithms. references #593 and #410

comment:4 Changed 11 years ago by Steve Williams

(In [2492]) Fixed some failing tests by changing code containing the modified function Property::isDefault() re #593

comment:5 Changed 11 years ago by Steve Williams

(In [2496]) Fixing broken tests from property::isDefault() changes. Bugs in load and save Nexus files remain. references #593

comment:6 Changed 11 years ago by Steve Williams

(In [2503]) To fix some Linux build failures refs #593

comment:7 Changed 11 years ago by Steve Williams

(In [2505]) Fixing test failures refs #593

comment:8 Changed 11 years ago by Steve Williams

(In [2510]) There maybe still be bugs due to changes to PropertyManager and isDefault() but I've checked all he isDefault() functions now refs #593

comment:9 Changed 11 years ago by Steve Williams

(In [2511]) Fixing the Linux build failures (forgotten <climits>) and some more algorithm descriptions refs #593 and #410

comment:10 Changed 11 years ago by Steve Williams

  • Status changed from assigned to closed
  • Resolution set to fixed

Errors are now generated when there is a problem setting properties. This is recorded in the log at debug and displayed to Mantidplot users. There could be some outstanding problems with setting properties but I know of no more work to do on this now.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1441

Note: See TracTickets for help on using tickets.