Ticket #6002 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

RenameWorkspace/GroupWorkspace not working

Reported by: Anders Markvardsen Owned by: Roman Tolchenov
Priority: blocker Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: #5666 Tester: Nick Draper

Description

Update code to include #5666 commit just pushed

1) Open MuonAnalysis interface

2) Hit browse button and load AutoTestData/MUSR00015189.nxs

3) Optionally close down MuonAnalysis interface + plot it created

4) Note that the WorkspaceGroup MUSR00015189 contain two workspaces:

MUSR00015189; Group=long; Asym; #1_1

MUSR00015189; Group=long; Asym; #1_2

5) Try to rename one of these workspaces. Excute RenameWorkspace, where e.g. use

InputWorkspace: MUSR00015189; Group=long; Asym; #1_1

OutputWorkspace: pain

6) Note that wrongly the new 'pain' workspace is placed OUTSIDE the WorkspaceGroup MUSR00015189.

7) The correct behaviour of RenameWorkspace is not to move a workspace out of a WorkspaceGroup. For sanity you can test this by running RenameWorkspace with

InputWorkspace: MuoneAnalysis_1

OutputWorkspace: pain2

8) This bug may be the reason why I can't subsequently get GroupWorkspace to work at all subsequently

Change History

comment:1 Changed 8 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Roman Tolchenov

Re #6002. Groups didn't observe replace notifications.

Changeset: 0d34583831981772854898a98b1e30e57a05ce1e

comment:3 Changed 8 years ago by Roman Tolchenov

Re #6002. This should fix the workspace group.

Changeset: 40887541f23503e5cfa6ba3217cc2f4ec6e6c1a2

comment:4 Changed 8 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:6 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

tested using the well written script above, works fine now.

Also tested a few other scenarios outside of the muon interface, all work, including the evil one of renaming a member of a group to the name of the group. I half expected a crash, but it replaces the group and other members appear outside of the group.

comment:7 Changed 8 years ago by Roman Tolchenov

Re #6002. Groups didn't observe replace notifications.

Changeset: 0d34583831981772854898a98b1e30e57a05ce1e

comment:8 Changed 8 years ago by Roman Tolchenov

Re #6002. This should fix the workspace group.

Changeset: 40887541f23503e5cfa6ba3217cc2f4ec6e6c1a2

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6848

Note: See TracTickets for help on using tickets.