Ticket #614 (closed: duplicate)

Opened 11 years ago

Last modified 5 years ago

Fit1D: Allow specific curve fits to cutomise the Fit Quailty test

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: minor Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description (last modified by Nick Draper) (diff)

At the moment the Fit1D class uses the chi2 test for evaluating the quality of the fit. We should change this so that this is used as the default, but specific curve fits can choose to overload the function if they should wish.

An simple example is when a fit know that a certain parameter e.g. peak width will always be within a certain range 0-5. They could override the chi2 test and implement their own which would do the following.

  1. run the base chi2 test
  2. inspect the peak width value
  3. if it is out of range then apply a large penalty to the chi2 value.

A good example in one of our algorithms of this would be the hwhm (half width half maximum) in Lorenzian1D. This should never be negative.

Change History

comment:1 Changed 11 years ago by Nick Draper

  • Description modified (diff)

comment:2 Changed 11 years ago by Nick Draper

  • Milestone changed from Iteration 18 to Iteration 19

Moved as part of iteration 18 end

comment:3 Changed 11 years ago by Nick Draper

  • Milestone changed from Iteration 19 to Iteration 20

Moved as part of the end of Iteration 19

comment:4 Changed 10 years ago by Roman Tolchenov

  • Status changed from new to verify
  • Resolution set to duplicate

comment:5 Changed 10 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:6 Changed 10 years ago by Nick Draper

  • Status changed from verifying to closed

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1462

Note: See TracTickets for help on using tickets.