Ticket #642 (closed: duplicate)

Opened 11 years ago

Last modified 5 years ago

MantidPlot: No easy way of viewing which detectors contribute to a spectrum if > 1

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

The "copy detectors to table" output gives no indication that a spectrum has more that one detector (a DetectorGroup) contributing to it. The detector ID given is just that of the first detector in the group. It would be useful to have a way of getting at the full list of IDs.

Options: Does IDetector::getID() have to return an int, or could it be a string containing more information. Or perhaps we should add another method to IDetector for this.

Here are all the places getID is used:

Algorithms/src/CreateCalFileByNames.cpp: instrcalib[currentDet->getID()]=std::make_pair<int,int>(number++,top_group); Algorithms/src/CreateCalFileByNames.cpp: instrcalib[number++]=std::make_pair<int,int>(currentDet->getID(),top_group); API/src/Instrument.cpp: if ( !_detectorCache.insert( std::map<int, Geometry::IDetector*>::value_type(det->getID(), det) ).second ) API/src/Instrument.cpp: convert << det->getID(); DataHandling/src/FindDetectorsInShape.cpp: g_log.debug()<<"Detector contained in shape " << detector_sptr->getID() << std::endl; DataHandling/src/FindDetectorsInShape.cpp: foundDets.push_back(detector_sptr->getID()); DataHandling/src/LoadInstrument.cpp: convert << detector->getID(); DataHandling/src/MoveInstrumentComponent.cpp: if (det && det->getID() == id) return comp; DataHandling/src/SetScalingPSD.cpp: if (det) idet=det->getID(); Geometry/src/Detector.cpp:int Detector::getID() const Geometry/src/DetectorGroup.cpp: g_log.warning() << "Adding a detector (ID:" << det->getID() << ") that is flagged as masked." << std::endl; Geometry/src/DetectorGroup.cpp: if ( m_detectors.empty() ) m_id = det->getID(); Geometry/src/DetectorGroup.cpp: if ( m_detectors.insert( DetCollection::value_type(det->getID(), det) ).second ) Geometry/src/DetectorGroup.cpp: g_log.debug() << "Detector with ID " << det->getID() << " added to group." << std::endl; Geometry/src/DetectorGroup.cpp: g_log.warning() << "Detector with ID " << det->getID() << " is already in group." << std::endl; Geometry/src/DetectorGroup.cpp:int DetectorGroup::getID() const Geometry/src/ParDetector.cpp:int ParDetector::getID() const Geometry/src/ParDetector.cpp: return dynamic_cast<const Detector*>(m_base)->getID(); PythonAPI/src/PythonWrapper.cpp: int getID() const { PythonAPI/src/PythonWrapper.cpp: return call_method< int >(py_self, "getID"); PythonAPI/src/PythonWrapper.cpp: .def("getID", pure_virtual(&Mantid::Geometry::IDetector::getID))

Change History

comment:1 Changed 11 years ago by Nick Draper

  • Milestone changed from Iteration 18 to Iteration 19

Moved as part of iteration 18 end

comment:2 Changed 11 years ago by Nick Draper

  • Milestone changed from Iteration 19 to Iteration 20

Moved as part of the end of Iteration 19

comment:3 Changed 11 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Sofia Antony

Also we need to be able to display this in the "detectors table" in MantidPlot

comment:4 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:5 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:7 Changed 9 years ago by Nick Draper

  • Owner Sofia Antony deleted
  • Status changed from assigned to new

Taken from Sofia Antony's list after she left

comment:8 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:9 Changed 9 years ago by Nick Draper

  • Owner set to Anyone
  • Status changed from new to assigned
  • Component set to Mantid

comment:10 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:11 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:12 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:13 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:14 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:15 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:16 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:17 Changed 7 years ago by Russell Taylor

  • Owner changed from Anyone to Russell Taylor
  • Status changed from assigned to accepted

comment:18 Changed 7 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to duplicate

This was sorted in #6262.

comment:19 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:20 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Yes, indeed it was.

comment:21 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1490

Note: See TracTickets for help on using tickets.