Ticket #6462 (closed: fixed)
Enable GenerateEventsFilter to handle integer-type logs
| Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.5 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Russell Taylor |
Description
Some sample logs are of integer-type. Enable GenerateEventsFilter to handle this type of logs, because FilterByLogValue() has been enabled to do so (ticket #6267) and thus TimeSeriesProperty.
Test Information
Find an event file containing and integer typed time-series log and try filtering based on the value of that log. Such files/logs are hard to find, but LET00006278.nxs in the systemtests/Data directory is one (integer logs in there include total_counts). ADARA HYSPEC files (HYSA) also have some integer logs.
Previously, GenerateEventsFilter will quit immediately as it detects the specified log is not of double-type.
Change History
comment:2 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 12c1f85234ce8a3874aae5646b37b6b2f01be32e
comment:3 Changed 7 years ago by Wenduo Zhou
Make filter with integer log work. Refs #6462.
Changeset: 3f857c12a53230755399b5ec4c36d03601778da4
comment:4 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 12c1f85234ce8a3874aae5646b37b6b2f01be32e
comment:5 Changed 7 years ago by Wenduo Zhou
Make filter with integer log work. Refs #6462.
Changeset: 3f857c12a53230755399b5ec4c36d03601778da4
comment:6 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 99711b3915d480f313d2bc6b1b16ba8ca28ddd5b
comment:7 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 99711b3915d480f313d2bc6b1b16ba8ca28ddd5b
comment:8 Changed 7 years ago by Wenduo Zhou
- Status changed from accepted to verify
- Resolution set to fixed
comment:9 Changed 7 years ago by Wenduo Zhou
Removed some unused code. Refs #6462.
Changeset: a27a8aca357bfdb11178bd9ecfc4ca4c7b946b84
comment:10 Changed 7 years ago by Wenduo Zhou
Removed some unused code. Refs #6462.
Changeset: a27a8aca357bfdb11178bd9ecfc4ca4c7b946b84
comment:11 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:12 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 12c1f85234ce8a3874aae5646b37b6b2f01be32e
comment:13 Changed 7 years ago by Wenduo Zhou
Make filter with integer log work. Refs #6462.
Changeset: 3f857c12a53230755399b5ec4c36d03601778da4
comment:14 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 99711b3915d480f313d2bc6b1b16ba8ca28ddd5b
comment:15 Changed 7 years ago by Wenduo Zhou
Removed some unused code. Refs #6462.
Changeset: a27a8aca357bfdb11178bd9ecfc4ca4c7b946b84
comment:16 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 12c1f85234ce8a3874aae5646b37b6b2f01be32e
comment:17 Changed 7 years ago by Wenduo Zhou
Make filter with integer log work. Refs #6462.
Changeset: 3f857c12a53230755399b5ec4c36d03601778da4
comment:18 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 99711b3915d480f313d2bc6b1b16ba8ca28ddd5b
comment:19 Changed 7 years ago by Wenduo Zhou
Removed some unused code. Refs #6462.
Changeset: a27a8aca357bfdb11178bd9ecfc4ca4c7b946b84
comment:20 Changed 7 years ago by Wenduo Zhou
Enable some disabled unit tests. Refs #6462.
Changeset: 8198c98185d8b26cd68bc01172422eef3344a053
comment:21 Changed 7 years ago by Wenduo Zhou
Enable some disabled unit tests. Refs #6462.
Changeset: 8198c98185d8b26cd68bc01172422eef3344a053
comment:22 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 12c1f85234ce8a3874aae5646b37b6b2f01be32e
comment:23 Changed 7 years ago by Wenduo Zhou
Make filter with integer log work. Refs #6462.
Changeset: 3f857c12a53230755399b5ec4c36d03601778da4
comment:24 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 99711b3915d480f313d2bc6b1b16ba8ca28ddd5b
comment:25 Changed 7 years ago by Wenduo Zhou
Removed some unused code. Refs #6462.
Changeset: a27a8aca357bfdb11178bd9ecfc4ca4c7b946b84
comment:26 Changed 7 years ago by Wenduo Zhou
Enable some disabled unit tests. Refs #6462.
Changeset: 8198c98185d8b26cd68bc01172422eef3344a053
comment:27 Changed 7 years ago by Russell Taylor
- Status changed from verifying to closed
Tested by comparing the events in the split workspaces to the numbers given by my SumEventsByLogValue algorithm for a scan run (scan_index is an integer log). The numbers are very slightly different, but this is down to the fact that this algorithm takes the neutron tofs into account whereas SumEventsByLogValue just looks at the pulse time. It's not obvious that one way is more correct than the others. A local modification to SumEventsByLogValue to account for tof gave exactly the same event counts.
comment:28 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 12c1f85234ce8a3874aae5646b37b6b2f01be32e
comment:29 Changed 7 years ago by Wenduo Zhou
Make filter with integer log work. Refs #6462.
Changeset: 3f857c12a53230755399b5ec4c36d03601778da4
comment:30 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 99711b3915d480f313d2bc6b1b16ba8ca28ddd5b
comment:31 Changed 7 years ago by Wenduo Zhou
Removed some unused code. Refs #6462.
Changeset: a27a8aca357bfdb11178bd9ecfc4ca4c7b946b84
comment:32 Changed 7 years ago by Wenduo Zhou
Enable some disabled unit tests. Refs #6462.
Changeset: 8198c98185d8b26cd68bc01172422eef3344a053
comment:33 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 12c1f85234ce8a3874aae5646b37b6b2f01be32e
comment:34 Changed 7 years ago by Wenduo Zhou
Make filter with integer log work. Refs #6462.
Changeset: 3f857c12a53230755399b5ec4c36d03601778da4
comment:35 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 99711b3915d480f313d2bc6b1b16ba8ca28ddd5b
comment:36 Changed 7 years ago by Wenduo Zhou
Removed some unused code. Refs #6462.
Changeset: a27a8aca357bfdb11178bd9ecfc4ca4c7b946b84
comment:37 Changed 7 years ago by Wenduo Zhou
Enable some disabled unit tests. Refs #6462.
Changeset: 8198c98185d8b26cd68bc01172422eef3344a053
comment:38 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 12c1f85234ce8a3874aae5646b37b6b2f01be32e
comment:39 Changed 7 years ago by Wenduo Zhou
Make filter with integer log work. Refs #6462.
Changeset: 3f857c12a53230755399b5ec4c36d03601778da4
comment:40 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 99711b3915d480f313d2bc6b1b16ba8ca28ddd5b
comment:41 Changed 7 years ago by Wenduo Zhou
Removed some unused code. Refs #6462.
Changeset: a27a8aca357bfdb11178bd9ecfc4ca4c7b946b84
comment:42 Changed 7 years ago by Wenduo Zhou
Enable some disabled unit tests. Refs #6462.
Changeset: 8198c98185d8b26cd68bc01172422eef3344a053
comment:43 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 12c1f85234ce8a3874aae5646b37b6b2f01be32e
comment:44 Changed 7 years ago by Wenduo Zhou
Make filter with integer log work. Refs #6462.
Changeset: 3f857c12a53230755399b5ec4c36d03601778da4
comment:45 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 99711b3915d480f313d2bc6b1b16ba8ca28ddd5b
comment:46 Changed 7 years ago by Wenduo Zhou
Removed some unused code. Refs #6462.
Changeset: a27a8aca357bfdb11178bd9ecfc4ca4c7b946b84
comment:47 Changed 7 years ago by Wenduo Zhou
Enable some disabled unit tests. Refs #6462.
Changeset: 8198c98185d8b26cd68bc01172422eef3344a053
comment:48 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 12c1f85234ce8a3874aae5646b37b6b2f01be32e
comment:49 Changed 7 years ago by Wenduo Zhou
Make filter with integer log work. Refs #6462.
Changeset: 3f857c12a53230755399b5ec4c36d03601778da4
comment:50 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #6462.
Changeset: 99711b3915d480f313d2bc6b1b16ba8ca28ddd5b
comment:51 Changed 7 years ago by Wenduo Zhou
Removed some unused code. Refs #6462.
Changeset: a27a8aca357bfdb11178bd9ecfc4ca4c7b946b84
comment:52 Changed 7 years ago by Wenduo Zhou
Enable some disabled unit tests. Refs #6462.
Changeset: 8198c98185d8b26cd68bc01172422eef3344a053
comment:53 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7308
