Ticket #6614 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Move system test scripts to new API

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: critical Milestone: Release 2.6
Component: Python Keywords: Maintenance
Cc: Blocked By: #7155
Blocking: Tester: Alex Buts

Description (last modified by Nick Draper) (diff)

The scripts that run the tests + the tests themselves need to be moved to the new API

Skip DirectInelaticSNS, Andrei is rewriting it anyway

Change History

comment:1 Changed 8 years ago by Martyn Gigg

Fix export maker test location. Refs #6614

Changeset: 1670a84edc458065ed2f8b13ee7ad7c2ae690017

comment:2 Changed 8 years ago by Martyn Gigg

Export MemoryStats class to Python. Refs #6614

Changeset: 2f43257855b04cd7b185eb90b133bfd1ec1df2d5

comment:3 Changed 8 years ago by Martyn Gigg

Fix MemoryStats test for older unittest modules. Refs #6614

Changeset: 8bb437dac9fab81de767fe61899a20a2c1057f98

comment:4 Changed 8 years ago by Martyn Gigg

Export saveConfig method of ConfigService Refs #6614

Changeset: ee721358f3a191d59c155c5927bf7f20f0abf354

comment:5 Changed 8 years ago by Martyn Gigg

Update isis direct system test to new api. Refs #6614

Changeset: 937a6a0dca8887fc9d7ceaebafabd65554f2160a

comment:6 Changed 8 years ago by Alex Buts

refs #6614 new API in inelastic direct user scripts

Changeset: 84d0e2d45a3ad220ebd46c809b76ad407221dbba

comment:7 Changed 8 years ago by Ricardo Leal

Re #6614 IN4 IDF and param file

Changeset: c3a55d660debd27415fe3525738e5d7e8b6ed698

comment:8 Changed 8 years ago by Ricardo Leal

Re #6614 Flat detector

Changeset: 31e5f4bde30b1a88f65484e454cdb50384988ae8

comment:9 Changed 8 years ago by Ricardo Leal

Re #6614 Cleaning up

Changeset: 1a2ee36af43d315bfed5e5292d3c599f6f1ad558

comment:10 Changed 8 years ago by Ricardo Leal

Re #6614 New ILL facilities

Changeset: 74cf2fb1ee3e110221427b0cb2ffec40d346e099

comment:11 Changed 8 years ago by Ricardo Leal

Re #6614 Changes to accomodate new instruments

Changeset: cb7eb3e17bb1c4fb243522c033d31c597876f1eb

comment:12 Changed 8 years ago by Alex Buts

refs #6614 new API in inelastic direct user scripts

Changeset: 84d0e2d45a3ad220ebd46c809b76ad407221dbba

comment:13 Changed 8 years ago by Ricardo Leal

Re #6614 Updated IN4 definition

Changeset: 613a476592330efb1efb89ec1b5eea541576c256

comment:14 Changed 8 years ago by Ricardo Leal

Re #6614 IN4 IDF and param file

Changeset: a99121237954c1641eeb967de31afc1e7b35bde3

comment:15 Changed 8 years ago by Ricardo Leal

Re #6614 Flat detector

Changeset: f1f0b3058b5dde30cf035e4154f6c6714453f37b

comment:16 Changed 8 years ago by Ricardo Leal

Re #6614 Cleaning up

Changeset: 522bec8664fe3071cae0afc642af5a4ec4e4447a

comment:17 Changed 8 years ago by Ricardo Leal

Re #6614 New ILL facilities

Changeset: 3c58d87710e7364733743ede1f54c4f8a229aaab

comment:18 Changed 8 years ago by Ricardo Leal

Re #6614 Changes to accomodate new instruments

Changeset: 8f5210bc0ca01610fa756bacb7fd743a78a28f5a

comment:19 Changed 8 years ago by Ricardo Leal

Re #6614 Updated IN4 definition

Changeset: 2f76197ff9028d730610108a1bfa9f7d5b37657e

comment:20 Changed 8 years ago by Ricardo Leal

Re #6614 IN4 IDF and param file

Changeset: a99121237954c1641eeb967de31afc1e7b35bde3

comment:21 Changed 8 years ago by Ricardo Leal

Re #6614 Flat detector

Changeset: f1f0b3058b5dde30cf035e4154f6c6714453f37b

comment:22 Changed 8 years ago by Ricardo Leal

Re #6614 Cleaning up

Changeset: 522bec8664fe3071cae0afc642af5a4ec4e4447a

comment:23 Changed 8 years ago by Ricardo Leal

Re #6614 New ILL facilities

Changeset: 3c58d87710e7364733743ede1f54c4f8a229aaab

comment:24 Changed 8 years ago by Ricardo Leal

Re #6614 Changes to accomodate new instruments

Changeset: 8f5210bc0ca01610fa756bacb7fd743a78a28f5a

comment:25 Changed 8 years ago by Ricardo Leal

Re #6614 Updated IN4 definition

Changeset: 2f76197ff9028d730610108a1bfa9f7d5b37657e

comment:26 Changed 8 years ago by Ricardo Leal

Re #6614 IN4 IDF and param file

Changeset: a99121237954c1641eeb967de31afc1e7b35bde3

comment:27 Changed 8 years ago by Ricardo Leal

Re #6614 Flat detector

Changeset: f1f0b3058b5dde30cf035e4154f6c6714453f37b

comment:28 Changed 8 years ago by Ricardo Leal

Re #6614 Cleaning up

Changeset: 522bec8664fe3071cae0afc642af5a4ec4e4447a

comment:29 Changed 8 years ago by Ricardo Leal

Re #6614 New ILL facilities

Changeset: 3c58d87710e7364733743ede1f54c4f8a229aaab

comment:30 Changed 8 years ago by Ricardo Leal

Re #6614 Changes to accomodate new instruments

Changeset: 8f5210bc0ca01610fa756bacb7fd743a78a28f5a

comment:31 Changed 8 years ago by Ricardo Leal

Re #6614 Updated IN4 definition

Changeset: 2f76197ff9028d730610108a1bfa9f7d5b37657e

comment:32 Changed 8 years ago by Ricardo Leal

Re #6614 IN4 IDF and param file

Changeset: a99121237954c1641eeb967de31afc1e7b35bde3

comment:33 Changed 8 years ago by Ricardo Leal

Re #6614 Flat detector

Changeset: f1f0b3058b5dde30cf035e4154f6c6714453f37b

comment:34 Changed 8 years ago by Ricardo Leal

Re #6614 Cleaning up

Changeset: 522bec8664fe3071cae0afc642af5a4ec4e4447a

comment:35 Changed 8 years ago by Ricardo Leal

Re #6614 New ILL facilities

Changeset: 3c58d87710e7364733743ede1f54c4f8a229aaab

comment:36 Changed 8 years ago by Ricardo Leal

Re #6614 Changes to accomodate new instruments

Changeset: 8f5210bc0ca01610fa756bacb7fd743a78a28f5a

comment:37 Changed 8 years ago by Ricardo Leal

Re #6614 Updated IN4 definition

Changeset: 2f76197ff9028d730610108a1bfa9f7d5b37657e

comment:38 Changed 8 years ago by Ricardo Leal

Re #6614 IN4 IDF and param file

Changeset: a99121237954c1641eeb967de31afc1e7b35bde3

comment:39 Changed 8 years ago by Ricardo Leal

Re #6614 Flat detector

Changeset: f1f0b3058b5dde30cf035e4154f6c6714453f37b

comment:40 Changed 8 years ago by Ricardo Leal

Re #6614 Cleaning up

Changeset: 522bec8664fe3071cae0afc642af5a4ec4e4447a

comment:41 Changed 8 years ago by Ricardo Leal

Re #6614 New ILL facilities

Changeset: 3c58d87710e7364733743ede1f54c4f8a229aaab

comment:42 Changed 8 years ago by Ricardo Leal

Re #6614 Changes to accomodate new instruments

Changeset: 8f5210bc0ca01610fa756bacb7fd743a78a28f5a

comment:43 Changed 8 years ago by Ricardo Leal

Re #6614 Updated IN4 definition

Changeset: 2f76197ff9028d730610108a1bfa9f7d5b37657e

comment:44 Changed 7 years ago by Ricardo Leal

Re #6614 IN4 IDF and param file

Changeset: a99121237954c1641eeb967de31afc1e7b35bde3

comment:45 Changed 7 years ago by Ricardo Leal

Re #6614 Flat detector

Changeset: f1f0b3058b5dde30cf035e4154f6c6714453f37b

comment:46 Changed 7 years ago by Ricardo Leal

Re #6614 Cleaning up

Changeset: 522bec8664fe3071cae0afc642af5a4ec4e4447a

comment:47 Changed 7 years ago by Ricardo Leal

Re #6614 New ILL facilities

Changeset: 3c58d87710e7364733743ede1f54c4f8a229aaab

comment:48 Changed 7 years ago by Ricardo Leal

Re #6614 Changes to accomodate new instruments

Changeset: 8f5210bc0ca01610fa756bacb7fd743a78a28f5a

comment:49 Changed 7 years ago by Ricardo Leal

Re #6614 Updated IN4 definition

Changeset: 2f76197ff9028d730610108a1bfa9f7d5b37657e

comment:50 Changed 7 years ago by Ricardo Leal

Re #6614 IN4 IDF and param file

Changeset: a99121237954c1641eeb967de31afc1e7b35bde3

comment:51 Changed 7 years ago by Ricardo Leal

Re #6614 Flat detector

Changeset: f1f0b3058b5dde30cf035e4154f6c6714453f37b

comment:52 Changed 7 years ago by Ricardo Leal

Re #6614 Cleaning up

Changeset: 522bec8664fe3071cae0afc642af5a4ec4e4447a

comment:53 Changed 7 years ago by Ricardo Leal

Re #6614 New ILL facilities

Changeset: 3c58d87710e7364733743ede1f54c4f8a229aaab

comment:54 Changed 7 years ago by Ricardo Leal

Re #6614 Changes to accomodate new instruments

Changeset: 8f5210bc0ca01610fa756bacb7fd743a78a28f5a

comment:55 Changed 7 years ago by Ricardo Leal

Re #6614 Updated IN4 definition

Changeset: 2f76197ff9028d730610108a1bfa9f7d5b37657e

comment:56 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:57 Changed 7 years ago by Martyn Gigg

  • Keywords Maintenance added
  • Description modified (diff)

comment:58 Changed 7 years ago by Martyn Gigg

Migrate all tests using automated script. Refs #6614

Changeset: 495a8055f526743cd1d3e991386b3fee259009a8

comment:59 Changed 7 years ago by Martyn Gigg

  • Blocked By 7155 added

comment:60 Changed 7 years ago by Martyn Gigg

Fix Offspec test and example test after migration. Refs #6614

Changeset: cfdfb25b8613e0e89740f812a91a292f52dc2783

comment:61 Changed 7 years ago by Martyn Gigg

Allow numpy boolean in return value of validate method. Refs #6614

Changeset: 89f73dd24bfa81385313a09a64500a21a1c1707a

comment:62 Changed 7 years ago by Martyn Gigg

Migrate PEARL system tests.

Pass by value and not string leads to very minor differences in GSS file but the level is acceptable. Refs #6614

Changeset: da6070982af3fe3008ff190f04cd7a6f277f0bd1

comment:63 Changed 7 years ago by Martyn Gigg

Move IndirectDiffractionTest to new API. Refs #6614

Changeset: 58ff568a393513164571d5cfbb61a323955a607f

comment:64 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/6614_api_migrate' into develop

comment:65 Changed 7 years ago by Martyn Gigg

Fix tests for new API. Refs #6614

Changeset: 878971a5907d4f67a4946b5708fd45a1a07bb54b

comment:66 Changed 7 years ago by Martyn Gigg

Use Load rather than LoadNexus in validation. Refs #6614

Changeset: a74f1050be728e56cfe60415534dd439eb7fed6c

comment:67 Changed 7 years ago by Martyn Gigg

Pull some tests back to old API. They depend on old API algorithms.

Refs #6614

Changeset: e64bd958cb527cfa94988d892df9f630fdbce52c

comment:68 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/6614_api_migrate' into develop

comment:69 Changed 7 years ago by Martyn Gigg

Fix more tests for new API. Refs #6614

Changeset: 1f74dbeec110fea57797b023efac44669d4c2fd0

comment:70 Changed 7 years ago by Martyn Gigg

Remaining fixes for v2 API tests. Refs #6614

Changeset: 7d45ec0dbfafd8a3402681dc2ed4e8c424dc6903

comment:71 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/6614_api_migrate' into develop

comment:72 Changed 7 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:73 Changed 7 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

Branch: feature/6614_api_migrate in the system test repository.

Tester:

There are two additional tickets, #7155 & #7156, that relate to changes in the main code repository that will require testing in conjunction with this ticket. Please contact me when you start testing this ticket and I will mark them as fixed (I have deliberately not closed them so they don't get picked up accidentally) so they can then be tested alongside.

As a minimum the system tests should be passing on develop. If you run them yourself then you will need to merge & build the aforementioned tickets first. A search of the tests should reveal no instances of MantidFramework or mantidsimple with the exceptions of those noted below.

The following tests were NOT migrated as they depend on other work still ongoing:

  • CalibrateRectangularDetector_Test.py
  • EQSANSLive.py
  • REFLReduction.py

Last edited 7 years ago by Martyn Gigg (previous) (diff)

comment:74 Changed 7 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:75 Changed 7 years ago by Alex Buts

  • Status changed from verifying to reopened
  • Resolution fixed deleted

classes 'EQSANSLive' EQSANSEff EQSANSIQOutput have not migrated, DirectInelasticDiagnostic suspected

comment:76 Changed 7 years ago by Martyn Gigg

Pull back a few EQSANS tests to the old API. They all have counterpart tests for the new API and will just be removed when API itself is removed.

Changeset: e3d994638d336b5332fb9bd1bbaef81f0eedd373

comment:77 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/6614_api_migrate' into develop

comment:78 Changed 7 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:79 Changed 7 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

The old EQSANS tests have been reverted back to the old API and will be removed when the old API is removed. They all have counterpart version 2 tests. DirectInelasticDiagnostic seems fine on my machine & on the build server.

comment:80 Changed 7 years ago by Alex Buts

  • Status changed from verify to verifying

comment:81 Changed 7 years ago by Alex Buts

  • Status changed from verifying to closed

Verified by building the Mantid without Python API module and running all tests. Apparently the only tests failing on my machine are the one with missing data files so all other stuff is probably correct.

comment:82 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:83 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Python API
  • Description modified (diff)

comment:84 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7460

Note: See TracTickets for help on using tickets.