Ticket #6677 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

WikiMaker debug mode

Reported by: Owen Arnold Owned by: Martyn Gigg
Priority: blocker Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Cannot use wikimaker with binaries created in debug mode. Most developers should be building mantid in debug mode, which makes it annoying to generate the documentation.

I'm happy to assist with this, but it's probably better that Martyn takes the lead given his superior knowledge of python.

Once this ticket is complete the oustanding issues section in http://www.mantidproject.org/Wiki_maker can be removed.

Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Priority changed from critical to blocker

comment:2 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Martyn Gigg

Note: I'm going to move the wiki maker to the second version of the API at the same time.

comment:4 Changed 8 years ago by Owen Arnold

Ok. Be warned, that I just made some changes to the wikimaker, these are currently not in master. See #6147.

comment:5 Changed 8 years ago by Martyn Gigg

Added Python helper class for testing alg deprecation. Refs #6677

Changeset: a55922e1d8feaa355740abf00dc838869c44dd94

comment:6 Changed 8 years ago by Martyn Gigg

Fix bug in IAlgorithm::categories export. Refs #6677

Changeset: 744536bade23b49345bc61a16d9f6a60f810cea1

comment:7 Changed 8 years ago by Martyn Gigg

Add type to Property python export. Refs #6677

Changeset: 62cc500afb154759f14d4b5010720759c04b0ee8

comment:8 Changed 8 years ago by Martyn Gigg

Standardize python property vs function on Property class. Refs #6677

Now behaves more consistently and like the original.

Changeset: b701fc708142d4e0bb57bd0a4af01aa3f4271b75

comment:9 Changed 8 years ago by Martyn Gigg

wiki_maker can now work with a debug build of Mantid on Windows

Any calls to mantid are done via a subprocess but only when running in debug so as not to compromise the speed of using it in release. Refs #6677

Changeset: 39a4113f2866f46454c9574b5052df29153febf6

comment:10 Changed 8 years ago by Martyn Gigg

Merge branch 'feature/6677_wikimaker_win_debug' into develop Refs #6677

Conflicts:

Code/Mantid/Build/wiki_maker.py

Changeset: 651dab2f7421234299047dca10c49397a39f48ef

comment:11 Changed 8 years ago by Martyn Gigg

Allow for property & function isValid types. Refs #6677

Changeset: d53698c69c1fac44211229d12826107b237ce5f0

comment:12 Changed 8 years ago by Martyn Gigg

Merge branch 'feature/6677_wikimaker_win_debug' into develop Refs #6677

Conflicts:

Code/Mantid/Framework/PythonInterface/mantid/simpleapi.py

Changeset: 1ab05b1d06508b8b7c76376c9e08a20ec5cb63e7

comment:13 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: The wiki_maker should now work with a debug build of Mantid on Windows. It is important however that the wiki_maker itself is still called with the standard python.exe. The calls to python_d are handled internally.

Note: The generation of pages for ALL algorithms is extremely slow. As most developers will be running this for a few algorithms and the job on the servers runs in release, whose performance is not affected, I believe this to be acceptable.

Branch: feature/6677_wikimaker_win_debug

comment:14 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:15 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Unfortunately, there is some complicated merging required here. Better to sort out on the original branch.

comment:16 Changed 8 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/master' into feature/6677_wikimaker_win_debug. Refs #6677

Wouldn't usually merge from master but these conflicts were quite involved to solve.

Conflicts:

Code/Mantid/Build/wiki_maker.py Code/Mantid/Framework/PythonInterface/mantid/simpleapi.py

Changeset: 9f9c6cf8dcefbbd4f5b0c7cf3a6797b5f622452a

comment:17 Changed 8 years ago by Martyn Gigg

Fixes for errors after conflict resolution. Refs #6677

Changeset: e82355922153e8f11db1ed3534924b286a7382b0

comment:18 Changed 8 years ago by Martyn Gigg

Added Python helper class for testing alg deprecation. Refs #6677

Changeset: a55922e1d8feaa355740abf00dc838869c44dd94

comment:19 Changed 8 years ago by Martyn Gigg

Fix bug in IAlgorithm::categories export. Refs #6677

Changeset: 744536bade23b49345bc61a16d9f6a60f810cea1

comment:20 Changed 8 years ago by Martyn Gigg

Add type to Property python export. Refs #6677

Changeset: 62cc500afb154759f14d4b5010720759c04b0ee8

comment:21 Changed 8 years ago by Martyn Gigg

Standardize python property vs function on Property class. Refs #6677

Now behaves more consistently and like the original.

Changeset: b701fc708142d4e0bb57bd0a4af01aa3f4271b75

comment:22 Changed 8 years ago by Martyn Gigg

wiki_maker can now work with a debug build of Mantid on Windows

Any calls to mantid are done via a subprocess but only when running in debug so as not to compromise the speed of using it in release. Refs #6677

Changeset: 39a4113f2866f46454c9574b5052df29153febf6

comment:23 Changed 8 years ago by Martyn Gigg

Allow for property & function isValid types. Refs #6677

Changeset: d53698c69c1fac44211229d12826107b237ce5f0

comment:24 Changed 8 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/master' into feature/6677_wikimaker_win_debug. Refs #6677

Wouldn't usually merge from master but these conflicts were quite involved to solve.

Conflicts:

Code/Mantid/Build/wiki_maker.py Code/Mantid/Framework/PythonInterface/mantid/simpleapi.py

Changeset: 9f9c6cf8dcefbbd4f5b0c7cf3a6797b5f622452a

comment:25 Changed 8 years ago by Martyn Gigg

Fixes for errors after conflict resolution. Refs #6677

Changeset: e82355922153e8f11db1ed3534924b286a7382b0

comment:26 Changed 8 years ago by Martyn Gigg

Merge branch 'feature/6677_wikimaker_win_debug' into develop. Refs #6677

Conflicts:

Code/Mantid/Build/wiki_maker.py

Changeset: 5d3e34bc7de9154cb34cf635ac455fa498aaafd7

comment:27 Changed 8 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:28 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

The conflicts have been resolved so this can be retested now.

comment:29 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying

comment:30 Changed 8 years ago by Martyn Gigg

Fix import statement. Refs #6677

Changeset: 23dae81166c010c213286ca3de8f5d88c37c8257

comment:31 Changed 8 years ago by Martyn Gigg

Fix import statement. Refs #6677

Changeset: 23dae81166c010c213286ca3de8f5d88c37c8257

comment:32 Changed 8 years ago by Martyn Gigg

Added Python helper class for testing alg deprecation. Refs #6677

Changeset: a55922e1d8feaa355740abf00dc838869c44dd94

comment:33 Changed 8 years ago by Martyn Gigg

Fix bug in IAlgorithm::categories export. Refs #6677

Changeset: 744536bade23b49345bc61a16d9f6a60f810cea1

comment:34 Changed 8 years ago by Martyn Gigg

Add type to Property python export. Refs #6677

Changeset: 62cc500afb154759f14d4b5010720759c04b0ee8

comment:35 Changed 8 years ago by Martyn Gigg

Standardize python property vs function on Property class. Refs #6677

Now behaves more consistently and like the original.

Changeset: b701fc708142d4e0bb57bd0a4af01aa3f4271b75

comment:36 Changed 8 years ago by Martyn Gigg

wiki_maker can now work with a debug build of Mantid on Windows

Any calls to mantid are done via a subprocess but only when running in debug so as not to compromise the speed of using it in release. Refs #6677

Changeset: 39a4113f2866f46454c9574b5052df29153febf6

comment:37 Changed 8 years ago by Martyn Gigg

Allow for property & function isValid types. Refs #6677

Changeset: d53698c69c1fac44211229d12826107b237ce5f0

comment:38 Changed 8 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/master' into feature/6677_wikimaker_win_debug. Refs #6677

Wouldn't usually merge from master but these conflicts were quite involved to solve.

Conflicts:

Code/Mantid/Build/wiki_maker.py Code/Mantid/Framework/PythonInterface/mantid/simpleapi.py

Changeset: 9f9c6cf8dcefbbd4f5b0c7cf3a6797b5f622452a

comment:39 Changed 8 years ago by Martyn Gigg

Fixes for errors after conflict resolution. Refs #6677

Changeset: e82355922153e8f11db1ed3534924b286a7382b0

comment:40 Changed 8 years ago by Martyn Gigg

Fix import statement. Refs #6677

Changeset: 23dae81166c010c213286ca3de8f5d88c37c8257

comment:41 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

Seems to work correctly in Debug mode now on windows.

comment:42 Changed 8 years ago by Martyn Gigg

Added Python helper class for testing alg deprecation. Refs #6677

Changeset: a55922e1d8feaa355740abf00dc838869c44dd94

comment:43 Changed 8 years ago by Martyn Gigg

Fix bug in IAlgorithm::categories export. Refs #6677

Changeset: 744536bade23b49345bc61a16d9f6a60f810cea1

comment:44 Changed 8 years ago by Martyn Gigg

Add type to Property python export. Refs #6677

Changeset: 62cc500afb154759f14d4b5010720759c04b0ee8

comment:45 Changed 8 years ago by Martyn Gigg

Standardize python property vs function on Property class. Refs #6677

Now behaves more consistently and like the original.

Changeset: b701fc708142d4e0bb57bd0a4af01aa3f4271b75

comment:46 Changed 8 years ago by Martyn Gigg

wiki_maker can now work with a debug build of Mantid on Windows

Any calls to mantid are done via a subprocess but only when running in debug so as not to compromise the speed of using it in release. Refs #6677

Changeset: 39a4113f2866f46454c9574b5052df29153febf6

comment:47 Changed 8 years ago by Martyn Gigg

Allow for property & function isValid types. Refs #6677

Changeset: d53698c69c1fac44211229d12826107b237ce5f0

comment:48 Changed 8 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/master' into feature/6677_wikimaker_win_debug. Refs #6677

Wouldn't usually merge from master but these conflicts were quite involved to solve.

Conflicts:

Code/Mantid/Build/wiki_maker.py Code/Mantid/Framework/PythonInterface/mantid/simpleapi.py

Changeset: 9f9c6cf8dcefbbd4f5b0c7cf3a6797b5f622452a

comment:49 Changed 8 years ago by Martyn Gigg

Fixes for errors after conflict resolution. Refs #6677

Changeset: e82355922153e8f11db1ed3534924b286a7382b0

comment:50 Changed 8 years ago by Martyn Gigg

Fix import statement. Refs #6677

Changeset: 23dae81166c010c213286ca3de8f5d88c37c8257

comment:51 Changed 8 years ago by Martyn Gigg

Added Python helper class for testing alg deprecation. Refs #6677

Changeset: a55922e1d8feaa355740abf00dc838869c44dd94

comment:52 Changed 8 years ago by Martyn Gigg

Fix bug in IAlgorithm::categories export. Refs #6677

Changeset: 744536bade23b49345bc61a16d9f6a60f810cea1

comment:53 Changed 8 years ago by Martyn Gigg

Add type to Property python export. Refs #6677

Changeset: 62cc500afb154759f14d4b5010720759c04b0ee8

comment:54 Changed 8 years ago by Martyn Gigg

Standardize python property vs function on Property class. Refs #6677

Now behaves more consistently and like the original.

Changeset: b701fc708142d4e0bb57bd0a4af01aa3f4271b75

comment:55 Changed 8 years ago by Martyn Gigg

wiki_maker can now work with a debug build of Mantid on Windows

Any calls to mantid are done via a subprocess but only when running in debug so as not to compromise the speed of using it in release. Refs #6677

Changeset: 39a4113f2866f46454c9574b5052df29153febf6

comment:56 Changed 8 years ago by Martyn Gigg

Allow for property & function isValid types. Refs #6677

Changeset: d53698c69c1fac44211229d12826107b237ce5f0

comment:57 Changed 8 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/master' into feature/6677_wikimaker_win_debug. Refs #6677

Wouldn't usually merge from master but these conflicts were quite involved to solve.

Conflicts:

Code/Mantid/Build/wiki_maker.py Code/Mantid/Framework/PythonInterface/mantid/simpleapi.py

Changeset: 9f9c6cf8dcefbbd4f5b0c7cf3a6797b5f622452a

comment:58 Changed 8 years ago by Martyn Gigg

Fixes for errors after conflict resolution. Refs #6677

Changeset: e82355922153e8f11db1ed3534924b286a7382b0

comment:59 Changed 8 years ago by Martyn Gigg

Fix import statement. Refs #6677

Changeset: 23dae81166c010c213286ca3de8f5d88c37c8257

comment:60 Changed 8 years ago by Martyn Gigg

Added Python helper class for testing alg deprecation. Refs #6677

Changeset: a55922e1d8feaa355740abf00dc838869c44dd94

comment:61 Changed 8 years ago by Martyn Gigg

Fix bug in IAlgorithm::categories export. Refs #6677

Changeset: 744536bade23b49345bc61a16d9f6a60f810cea1

comment:62 Changed 8 years ago by Martyn Gigg

Add type to Property python export. Refs #6677

Changeset: 62cc500afb154759f14d4b5010720759c04b0ee8

comment:63 Changed 8 years ago by Martyn Gigg

Standardize python property vs function on Property class. Refs #6677

Now behaves more consistently and like the original.

Changeset: b701fc708142d4e0bb57bd0a4af01aa3f4271b75

comment:64 Changed 8 years ago by Martyn Gigg

wiki_maker can now work with a debug build of Mantid on Windows

Any calls to mantid are done via a subprocess but only when running in debug so as not to compromise the speed of using it in release. Refs #6677

Changeset: 39a4113f2866f46454c9574b5052df29153febf6

comment:65 Changed 8 years ago by Martyn Gigg

Allow for property & function isValid types. Refs #6677

Changeset: d53698c69c1fac44211229d12826107b237ce5f0

comment:66 Changed 8 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/master' into feature/6677_wikimaker_win_debug. Refs #6677

Wouldn't usually merge from master but these conflicts were quite involved to solve.

Conflicts:

Code/Mantid/Build/wiki_maker.py Code/Mantid/Framework/PythonInterface/mantid/simpleapi.py

Changeset: 9f9c6cf8dcefbbd4f5b0c7cf3a6797b5f622452a

comment:67 Changed 8 years ago by Martyn Gigg

Fixes for errors after conflict resolution. Refs #6677

Changeset: e82355922153e8f11db1ed3534924b286a7382b0

comment:68 Changed 8 years ago by Martyn Gigg

Fix import statement. Refs #6677

Changeset: 23dae81166c010c213286ca3de8f5d88c37c8257

comment:69 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7523

Note: See TracTickets for help on using tickets.