Ticket #6828 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Upgrades to Material class

Reported by: Peter Peterson Owned by: Vickie Lynch
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

  • Move Material into Kernel.
  • Move the string parsing into the Material class rather than in SetSampleMaterial.
  • Make the reference wavelength (1.7982 angstroms) a constant for Material rather than a number that is copied into several different places.
  • Add the reference wavelength as the default value for the various neutronic accessor methods (cohScatterXSection, incohScatterXSection, etc)
  • Add a field to hold the chemical formula in a standardized format.

Change History

comment:1 Changed 8 years ago by Vickie Lynch

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Vickie Lynch

Refs #6828 move Material to Kernel

Changeset: 4e1be6f39e66180ebe6e09da48d63ff941200a75

comment:3 Changed 7 years ago by Vickie Lynch

Refs #6828 parser in Material; use ReferenceLambda constant

Changeset: 61b3a2b4a47edf387837391f940a57411d241448

comment:4 Changed 7 years ago by Vickie Lynch

Refs #6828 default values for wavelength

Changeset: 3b7717a7b5d1dc8892c9b310a3c6f33cd794e83c

comment:5 Changed 7 years ago by Vickie Lynch

Refs #6828 move Material to Kernel

Changeset: 4e1be6f39e66180ebe6e09da48d63ff941200a75

comment:6 Changed 7 years ago by Vickie Lynch

Refs #6828 parser in Material; use ReferenceLambda constant

Changeset: 61b3a2b4a47edf387837391f940a57411d241448

comment:7 Changed 7 years ago by Vickie Lynch

Refs #6828 default values for wavelength

Changeset: 3b7717a7b5d1dc8892c9b310a3c6f33cd794e83c

comment:8 Changed 7 years ago by Vickie Lynch

Refs #6828 resolve conflict with my changes

Changeset: 62fb5bb174dc17578a2e161307976e62acb3af4f

comment:9 Changed 7 years ago by Vickie Lynch

Refs #6828 struct for ChemicalFormula

Changeset: 0448d8c523286b0671c922ea03c026efa8a98734

comment:10 Changed 7 years ago by Vickie Lynch

Refs #6828 struct for ChemicalFormula

Changeset: 0448d8c523286b0671c922ea03c026efa8a98734

comment:11 Changed 7 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

All changes completed. To test, use SetSampleMaterial and check prints in window.

comment:12 Changed 7 years ago by Vickie Lynch

Refs #6828 move Material to Kernel

Changeset: 4e1be6f39e66180ebe6e09da48d63ff941200a75

comment:13 Changed 7 years ago by Vickie Lynch

Refs #6828 parser in Material; use ReferenceLambda constant

Changeset: 61b3a2b4a47edf387837391f940a57411d241448

comment:14 Changed 7 years ago by Vickie Lynch

Refs #6828 default values for wavelength

Changeset: 3b7717a7b5d1dc8892c9b310a3c6f33cd794e83c

comment:15 Changed 7 years ago by Vickie Lynch

Refs #6828 resolve conflict with my changes

Changeset: 62fb5bb174dc17578a2e161307976e62acb3af4f

comment:16 Changed 7 years ago by Vickie Lynch

Refs #6828 struct for ChemicalFormula

Changeset: 0448d8c523286b0671c922ea03c026efa8a98734

comment:17 Changed 7 years ago by Vickie Lynch

Refs #6828 move Material to Kernel

Changeset: 4e1be6f39e66180ebe6e09da48d63ff941200a75

comment:18 Changed 7 years ago by Vickie Lynch

Refs #6828 parser in Material; use ReferenceLambda constant

Changeset: 61b3a2b4a47edf387837391f940a57411d241448

comment:19 Changed 7 years ago by Vickie Lynch

Refs #6828 default values for wavelength

Changeset: 3b7717a7b5d1dc8892c9b310a3c6f33cd794e83c

comment:20 Changed 7 years ago by Vickie Lynch

Refs #6828 resolve conflict with my changes

Changeset: 62fb5bb174dc17578a2e161307976e62acb3af4f

comment:21 Changed 7 years ago by Vickie Lynch

Refs #6828 struct for ChemicalFormula

Changeset: 0448d8c523286b0671c922ea03c026efa8a98734

comment:22 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:23 Changed 7 years ago by Vickie Lynch

Refs #6828 move Material to Kernel

Changeset: 4e1be6f39e66180ebe6e09da48d63ff941200a75

comment:24 Changed 7 years ago by Vickie Lynch

Refs #6828 parser in Material; use ReferenceLambda constant

Changeset: 61b3a2b4a47edf387837391f940a57411d241448

comment:25 Changed 7 years ago by Vickie Lynch

Refs #6828 default values for wavelength

Changeset: 3b7717a7b5d1dc8892c9b310a3c6f33cd794e83c

comment:26 Changed 7 years ago by Vickie Lynch

Refs #6828 resolve conflict with my changes

Changeset: 62fb5bb174dc17578a2e161307976e62acb3af4f

comment:27 Changed 7 years ago by Vickie Lynch

Refs #6828 struct for ChemicalFormula

Changeset: 0448d8c523286b0671c922ea03c026efa8a98734

comment:28 Changed 7 years ago by Vickie Lynch

Refs #6828 move Material to Kernel

Changeset: 4e1be6f39e66180ebe6e09da48d63ff941200a75

comment:29 Changed 7 years ago by Vickie Lynch

Refs #6828 parser in Material; use ReferenceLambda constant

Changeset: 61b3a2b4a47edf387837391f940a57411d241448

comment:30 Changed 7 years ago by Vickie Lynch

Refs #6828 default values for wavelength

Changeset: 3b7717a7b5d1dc8892c9b310a3c6f33cd794e83c

comment:31 Changed 7 years ago by Vickie Lynch

Refs #6828 resolve conflict with my changes

Changeset: 62fb5bb174dc17578a2e161307976e62acb3af4f

comment:32 Changed 7 years ago by Vickie Lynch

Refs #6828 struct for ChemicalFormula

Changeset: 0448d8c523286b0671c922ea03c026efa8a98734

comment:33 Changed 7 years ago by Vickie Lynch

Refs #6828 move Material to Kernel

Changeset: 4e1be6f39e66180ebe6e09da48d63ff941200a75

comment:34 Changed 7 years ago by Vickie Lynch

Refs #6828 parser in Material; use ReferenceLambda constant

Changeset: 61b3a2b4a47edf387837391f940a57411d241448

comment:35 Changed 7 years ago by Vickie Lynch

Refs #6828 default values for wavelength

Changeset: 3b7717a7b5d1dc8892c9b310a3c6f33cd794e83c

comment:36 Changed 7 years ago by Vickie Lynch

Refs #6828 resolve conflict with my changes

Changeset: 62fb5bb174dc17578a2e161307976e62acb3af4f

comment:37 Changed 7 years ago by Vickie Lynch

Refs #6828 struct for ChemicalFormula

Changeset: 0448d8c523286b0671c922ea03c026efa8a98734

comment:38 Changed 7 years ago by Vickie Lynch

Refs #6828 move Material to Kernel

Changeset: 4e1be6f39e66180ebe6e09da48d63ff941200a75

comment:39 Changed 7 years ago by Vickie Lynch

Refs #6828 parser in Material; use ReferenceLambda constant

Changeset: 61b3a2b4a47edf387837391f940a57411d241448

comment:40 Changed 7 years ago by Vickie Lynch

Refs #6828 default values for wavelength

Changeset: 3b7717a7b5d1dc8892c9b310a3c6f33cd794e83c

comment:41 Changed 7 years ago by Vickie Lynch

Refs #6828 struct for ChemicalFormula

Changeset: 0448d8c523286b0671c922ea03c026efa8a98734

comment:42 Changed 7 years ago by Andrei Savici

git merge created an extra bracket. Refs #6828.

Changeset: fdb436c02e6a42a9f86ad76ccdd43f210e77a71e

comment:43 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

More bugs to be fixed in #6719

comment:44 Changed 7 years ago by Andrei Savici

git merge created an extra bracket. Refs #6828.

Changeset: fdb436c02e6a42a9f86ad76ccdd43f210e77a71e

comment:45 Changed 7 years ago by Vickie Lynch

Refs #6828 move Material to Kernel

Changeset: 4e1be6f39e66180ebe6e09da48d63ff941200a75

comment:46 Changed 7 years ago by Vickie Lynch

Refs #6828 parser in Material; use ReferenceLambda constant

Changeset: 61b3a2b4a47edf387837391f940a57411d241448

comment:47 Changed 7 years ago by Vickie Lynch

Refs #6828 default values for wavelength

Changeset: 3b7717a7b5d1dc8892c9b310a3c6f33cd794e83c

comment:48 Changed 7 years ago by Vickie Lynch

Refs #6828 struct for ChemicalFormula

Changeset: 0448d8c523286b0671c922ea03c026efa8a98734

comment:49 Changed 7 years ago by Andrei Savici

git merge created an extra bracket. Refs #6828.

Changeset: fdb436c02e6a42a9f86ad76ccdd43f210e77a71e

comment:50 Changed 7 years ago by Vickie Lynch

Refs #6828 move Material to Kernel

Changeset: 4e1be6f39e66180ebe6e09da48d63ff941200a75

comment:51 Changed 7 years ago by Vickie Lynch

Refs #6828 parser in Material; use ReferenceLambda constant

Changeset: 61b3a2b4a47edf387837391f940a57411d241448

comment:52 Changed 7 years ago by Vickie Lynch

Refs #6828 default values for wavelength

Changeset: 3b7717a7b5d1dc8892c9b310a3c6f33cd794e83c

comment:53 Changed 7 years ago by Vickie Lynch

Refs #6828 struct for ChemicalFormula

Changeset: 0448d8c523286b0671c922ea03c026efa8a98734

comment:54 Changed 7 years ago by Andrei Savici

git merge created an extra bracket. Refs #6828.

Changeset: fdb436c02e6a42a9f86ad76ccdd43f210e77a71e

comment:55 Changed 7 years ago by Vickie Lynch

Merge branch 'feature/6828_UpgradeMaterials' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:56 Changed 7 years ago by Vickie Lynch

Merge branch 'feature/6828_UpgradeMaterials' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:57 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7674

Note: See TracTickets for help on using tickets.