Ticket #6926 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Inst view: Peak HKL calculation should be able to use UB matrix from data WS

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: critical Milestone: Release 2.5
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

as well as using the UB from a peak list, Mantid should also be able to use the UB on the data ws if one is present.

If both are present then use the one from the peak list (as that is where new peak will be put).

Also ensure that when a new peak list is created then the UB matrix from the data is copied to the peak list is one is available.

Change History

comment:1 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Roman Tolchenov

Copy UB matrix from data WS to peaks WS when adding peaks. Re #6926.

Changeset: 10daa8265d83f3d2a0df5b35dbf6736b8f163516

comment:3 Changed 7 years ago by Roman Tolchenov

Copy UB matrix from data WS to peaks WS when adding peaks. Re #6926.

Changeset: 10daa8265d83f3d2a0df5b35dbf6736b8f163516

comment:4 Changed 7 years ago by Roman Tolchenov

Only copy UB to new peaks workspace. Re #6926.

Changeset: 8d1e9d00063dac0baaf5815b7a95de3f760e8fc5

comment:5 Changed 7 years ago by Roman Tolchenov

Only copy UB to new peaks workspace. Re #6926.

Changeset: 8d1e9d00063dac0baaf5815b7a95de3f760e8fc5

comment:6 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

To tester

branch feature/6926_HKL_calculation_in_instrument_view

I have two test data sets with and without UB but they are too large for attachment.

comment:7 Changed 7 years ago by Roman Tolchenov

Copy UB matrix from data WS to peaks WS when adding peaks. Re #6926.

Changeset: 10daa8265d83f3d2a0df5b35dbf6736b8f163516

comment:8 Changed 7 years ago by Roman Tolchenov

Only copy UB to new peaks workspace. Re #6926.

Changeset: 8d1e9d00063dac0baaf5815b7a95de3f760e8fc5

comment:9 Changed 7 years ago by Roman Tolchenov

Copy UB matrix from data WS to peaks WS when adding peaks. Re #6926.

Changeset: 10daa8265d83f3d2a0df5b35dbf6736b8f163516

comment:10 Changed 7 years ago by Roman Tolchenov

Only copy UB to new peaks workspace. Re #6926.

Changeset: 8d1e9d00063dac0baaf5815b7a95de3f760e8fc5

comment:11 Changed 7 years ago by Roman Tolchenov

Copy UB matrix from data WS to peaks WS when adding peaks. Re #6926.

Changeset: 10daa8265d83f3d2a0df5b35dbf6736b8f163516

comment:12 Changed 7 years ago by Roman Tolchenov

Only copy UB to new peaks workspace. Re #6926.

Changeset: 8d1e9d00063dac0baaf5815b7a95de3f760e8fc5

comment:13 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:14 Changed 7 years ago by Roman Tolchenov

Copy UB matrix from data WS to peaks WS when adding peaks. Re #6926.

Changeset: c01c018873ea3d4f743b14499a3eb2b81150dc71

comment:15 Changed 7 years ago by Roman Tolchenov

Only copy UB to new peaks workspace. Re #6926.

Changeset: bf9b8ad078707a6b21a06221a47947d2c3b7e549

comment:16 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

comment:17 Changed 7 years ago by Roman Tolchenov

Copy UB matrix from data WS to peaks WS when adding peaks. Re #6926.

Changeset: c01c018873ea3d4f743b14499a3eb2b81150dc71

comment:18 Changed 7 years ago by Roman Tolchenov

Only copy UB to new peaks workspace. Re #6926.

Changeset: bf9b8ad078707a6b21a06221a47947d2c3b7e549

comment:19 Changed 7 years ago by Roman Tolchenov

Copy UB matrix from data WS to peaks WS when adding peaks. Re #6926.

Changeset: c01c018873ea3d4f743b14499a3eb2b81150dc71

comment:20 Changed 7 years ago by Roman Tolchenov

Only copy UB to new peaks workspace. Re #6926.

Changeset: bf9b8ad078707a6b21a06221a47947d2c3b7e549

comment:21 Changed 7 years ago by Roman Tolchenov

Copy UB matrix from data WS to peaks WS when adding peaks. Re #6926.

Changeset: c01c018873ea3d4f743b14499a3eb2b81150dc71

comment:22 Changed 7 years ago by Roman Tolchenov

Only copy UB to new peaks workspace. Re #6926.

Changeset: bf9b8ad078707a6b21a06221a47947d2c3b7e549

comment:23 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6926_HKL_calculation_in_instrument_view' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:24 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6926_HKL_calculation_in_instrument_view' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:25 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6926_HKL_calculation_in_instrument_view' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:26 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6926_HKL_calculation_in_instrument_view' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:27 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7772

Note: See TracTickets for help on using tickets.