Ticket #6939 (closed: worksforme)
Make checking for live stream connection asynchronous in the Step Scan Interface
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description (last modified by Russell Taylor) (diff)
I've noticed that on the Mac the attempt to connect to the HYSPEC live stream (which will fail) takes a noticeable amount of time (on RHEL6 it seemed instantaneous).
I need to move this checking into another thread, probably using QtConcurrent::run & a QFutureWatcher.
Change History
comment:5 Changed 7 years ago by Owen Arnold
Aplogies, commites relating to "PATH" and Unused include above, should have gone against #6936
comment:6 Changed 7 years ago by Owen Arnold
refs #6939. PATH changes don't propegate through.
Changeset: 6d4998391b4a65c3fd09a3d81c5fe07bf5a84b25
comment:13 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to the Backlog after the code freeze for R2.6
comment:14 Changed 7 years ago by Russell Taylor
- Description modified (diff)
- Milestone changed from Backlog to Release 3.0
comment:15 Changed 7 years ago by Russell Taylor
- Status changed from new to verify
- Resolution set to worksforme
Don't know what changed, but it seems fine now.
To test, be on a Mac and set your default instrument to HFIR. Select Interfaces->Step Scan Analysis and the GUI should come up immediately, with the live stream button disabled.
It would also be interesting, though not essential, to check this on other platforms and for other instruments - e.g. ISIS ones where the connection is possible, SNS ones apart from HYS & SEQ (which have no live listener address set).
comment:16 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:17 Changed 7 years ago by Michael Reuter
This seems to work fine on Ubuntu and RHEL6 for all combinations of facility/instrument that I tests. I tested some with the live stream, but the majority without. Response of the GUI appearance was fine. I tested this on Windows and things work OK for SNS and HFIR instruments. When I tested ISIS instruments, there was a noticeable pause before the dialog appeared. Still getting the Mac built.
comment:18 Changed 7 years ago by Michael Reuter
On Mac this works fine and no delay is seen no matter what combination of facility/instrument is used.
comment:20 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7785
refs #6939. Unused include.