Ticket #7082 (closed: fixed)
Migrate MergeCalFiles
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.6 |
| Component: | Python | Keywords: | Maintenance |
| Cc: | Blocked By: | ||
| Blocking: | #6579 | Tester: | Nick Draper |
Description (last modified by Nick Draper) (diff)
Migrate MergeCalFiles
- Migrate to v2 of the python API
- Move to PythonInteface/plugins/algorithms directory
- Add unit test
Change History
comment:2 Changed 7 years ago by Owen Arnold
refs #7082. Port to new api.
Changeset: 0ebca5d6c2a97c30f7df13c8091851438b7ed795
comment:3 Changed 7 years ago by Owen Arnold
refs #7082. Move location.
Changeset: 6d9ac55008dbf3b4d668c5e439d1b534ce0f345b
comment:4 Changed 7 years ago by Owen Arnold
refs #7082. Add unit test for MergeCalFilesTest.
In the process discover that the algorithm was actually broken, so fix that too and add tests for the broken->fixed cases.!
Changeset: 227703b269515069b4c910820dc95f331ed8dacf
comment:5 Changed 7 years ago by Owen Arnold
refs #7082. Port to new api.
Changeset: 0ebca5d6c2a97c30f7df13c8091851438b7ed795
comment:6 Changed 7 years ago by Owen Arnold
refs #7082. Move location.
Changeset: 6d9ac55008dbf3b4d668c5e439d1b534ce0f345b
comment:7 Changed 7 years ago by Owen Arnold
refs #7082. Add unit test for MergeCalFilesTest.
In the process discover that the algorithm was actually broken, so fix that too and add tests for the broken->fixed cases.!
Changeset: 227703b269515069b4c910820dc95f331ed8dacf
comment:8 Changed 7 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
Tester. There is a new unit test, which should cover a large portion of the functionality. To perform manual testing, you might use the instrumentview masking tools to create two cal files as inputs for this algorithm, and inspect the output cal file after merging with various options applied.
comment:10 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:11 Changed 7 years ago by Owen Arnold
refs #7082. Port to new api.
Changeset: 0ebca5d6c2a97c30f7df13c8091851438b7ed795
comment:12 Changed 7 years ago by Owen Arnold
refs #7082. Move location.
Changeset: 6d9ac55008dbf3b4d668c5e439d1b534ce0f345b
comment:13 Changed 7 years ago by Owen Arnold
refs #7082. Add unit test for MergeCalFilesTest.
In the process discover that the algorithm was actually broken, so fix that too and add tests for the broken->fixed cases.!
Changeset: 227703b269515069b4c910820dc95f331ed8dacf
comment:14 Changed 7 years ago by Nick Draper
re #7082 remove logging left over from debugging
Changeset: 01fa75b45a428f1458633cf1a03e401d855722ea
comment:15 Changed 7 years ago by Nick Draper
re #7082 remove logging left over from debugging
Changeset: 01fa75b45a428f1458633cf1a03e401d855722ea
comment:16 Changed 7 years ago by Nick Draper
- Status changed from verifying to closed
Passed testing both using the unit tests and manual testing with sample cal files.
Did remove a few diagnostic logging lines as part of the merge.
comment:18 Changed 7 years ago by Nick Draper
- Component changed from Framework to Python API
- Description modified (diff)
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7928
