Ticket #7084 (closed: fixed)
Mantidplot crash when changing the connecting line
| Reported by: | Nick Draper | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.5.3 |
| Component: | Mantid | Keywords: | PatchCandidate,Released |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Owen Arnold |
Description
Plot a graph, right-click, select Properties, select a dataset, and attempt to change 'connect' (eg, from lines to dots). Results in an immediate unrecoverable hang and you have to close the program!
Change History
comment:2 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Release 2.5.3
Moved to patch release
comment:3 Changed 7 years ago by Martyn Gigg
Fix plot dialog crash when changing plot type.
The problem was the fix with in commit 4c6aa2f0373774639892a5b9304c93eaed857a2a. It caused an infinite recursion on the plot dialog where the change signals are directly connected to the plot updating. The signals are now not dispatched when the text is interpreted for the value call. Refs #7084
Changeset: 083aa0fb3318d059f160c003c5b1ebfa8cbcf0f6
comment:4 Changed 7 years ago by Martyn Gigg
Fix plot dialog crash when changing plot type.
The problem was the fix with in commit 4c6aa2f0373774639892a5b9304c93eaed857a2a. It caused an infinite recursion on the plot dialog where the change signals are directly connected to the plot updating. The signals are now not dispatched when the text is interpreted for the value call. Refs #7084
Changeset: 083aa0fb3318d059f160c003c5b1ebfa8cbcf0f6
comment:5 Changed 7 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
Branch: bugfix/7084_crash_plot_dialog
Tester:
- Check the above steps don't crash the application any more
- The fix to #7036 actually caused this. So please check that the testing steps in that ticket also still work.
comment:6 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:7 Changed 7 years ago by Nick Draper
- Status changed from verifying to verify
- Tester Nick Draper deleted
Tested with workspace and simple table data on windows 7. Left open for someone with a Mac to test that #7-36 still works, if it does then do the merge.
comment:8 Changed 7 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:9 Changed 7 years ago by Martyn Gigg
Fix plot dialog crash when changing plot type.
The problem was the fix with in commit 4c6aa2f0373774639892a5b9304c93eaed857a2a. It caused an infinite recursion on the plot dialog where the change signals are directly connected to the plot updating. The signals are now not dispatched when the text is interpreted for the value call. Refs #7084
Changeset: 083aa0fb3318d059f160c003c5b1ebfa8cbcf0f6
comment:10 Changed 7 years ago by Owen Arnold
- Status changed from verifying to closed
Tested the previous fix #7036, which remains fixed on the Mac.
comment:11 Changed 7 years ago by Martyn Gigg
Fix plot dialog crash when changing plot type.
The problem was the fix with in commit 4c6aa2f0373774639892a5b9304c93eaed857a2a. It caused an infinite recursion on the plot dialog where the change signals are directly connected to the plot updating. The signals are now not dispatched when the text is interpreted for the value call. Refs #7084
Changeset: 9c524549a075adfafde51f3f0e0c4d73f4a1008d
comment:12 Changed 7 years ago by Nick Draper
- Keywords PatchCandidate,Released added; PatchCandidate removed
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7930
