Fix ConvertSpectrumAxis algorithm

[Dereck Kachere]

Currently, ConvertToSpectrumAxis is incorrectly converting from theta to Q. The algorithm is used by Elwin, meaning all the output workspaces from the Elwin interface are wrong.

Fix this and look into the possibility of limiting the conversions carried out by this algorithm.

[Dereck Kachere]

refs #7144 New versions of the algorithm.

First few changes.

Changeset: 6962092ef393b25b41c6909ab2c33c37c6991201

[Dereck Kachere]

refs #7144 Refactored old alg

Changeset: 3e823dc2c0e3766f3d060bc9fe1f4be1e4607218

[Dereck Kachere]

refs #7144 More refactoring

Work in progress still

Changeset: ba26da9ee59df702050104bd5e69d62743a0b7bd

[Dereck Kachere]

refs #7144 Latest version of the alg and unit test.

Changeset: c6c4a2eb8593392fd795b2f32cafd8b4836207bb

[Dereck Kachere]

refs #7144 Few more additions - test still under construction.

Changeset: 94b7243c79a19314c86ed01c967f47cf1bbd5c87

[Dereck Kachere]

refs #7144 More up-to-date version

Q and QSquared values in the algorithm are given in units of Angstroms

Changeset: 66017e538916706cb70a8e6f5898528bc0c9f9eb

[Dereck Kachere]

refs #7144 Added a couple more tests

A bit of refactoring needed to finalise the algorithm and the test.

Changeset: 31fca5e0fa4f1a2eabbc6bea28e3052e3ed20ff3

[Dereck Kachere]

refs #7144 Refactored code and made a few additions and deletions.

Changeset: 373758ba1cdf465098ae2df0560b3a7bb188b2b0

[Dereck Kachere]

refs #7144 Solved a conflict

Changeset: 426770544448d60e69c35b192f8865aa9722e353

[Dereck Kachere]

refs #7144 Modified overloads on helper function.

Helper function was modified for unit test purposes.

Changeset: 3b1361e8932b6dae6ca5c2bf0ece41c6ec9f9d6e

[Dereck Kachere]

refs #7144 Some more refactoring

Changeset: 57765ec2e9aac127eedf87e133ae3fba7fdf326e

[Dereck Kachere]

refs #7144 Corrected the inputs for energy.

The input was in Joules and not in meV and were not accounted for in the calculations.

Changeset: 93b4ceb74fd6ea2f1b7a6634997434020fc81c12

[Dereck Kachere]

refs #7144 Files for new version of ConvertSpectrumAxis algorithm.

Changeset: 686498f3bdf97ff7841a40fdcf68892c6277770f

[Dereck Kachere]

A systemtest branch of the same name - 7144_new_v_cov_spectrum_axis - needs to be merged into master at the same time as this ticket

[Dereck Kachere]

refs #7144 Updated reference results.

Changeset: d2b93d1e36f8740b4de48f92ac80ef5664100b5e

[Dereck Kachere]

refs #7144 Removed unused variable.

Changeset: 126380b256dc4a673e37b9d21390a57a2a1302c7

[Martyn Gigg]

Fix bug in Q calculation. Use theta not 2 theta. Refs #7144

Changeset: 3e539ea8758bf08a39ff38d7180a735a836fcb1f

[Martyn Gigg]

Add progress reporting to elastic window. Refs #7144

Changeset: 0b88e6fe0dba4214e242706c134c91ba72ed5b06

[Martyn Gigg]

Update reference results for Elwin & MSDFit

Fixing ConvertSpectrumAxis requires an update to the results. Refs #7144

Changeset: de8ad759836e48319ea2e85f3edfdc56c227aab4

[Martyn Gigg]

Branch: feature/7144_new_v_conv_spectrum_axis in both code and systemtests repos

Tester: Use the script below to check the values are what you expect by displaying the detector table to see the two theta angles (labelled Theta!) and using Q=4*pi*sin(theta)/lambda & lambda = sqrt(81.787/efixed) where efixed = 1.845 meV

nxs = Load(Filename="irs26176_graphite002_red.nxs")
ws = ConvertSpectrumAxis(InputWorkspace=nxs,Target="ElasticQ")

axis1 = ws.getAxis(1)
print ws.getValue(0)
print ws.getValue(1)

[Arturs Bekasovs]

Merge remote-tracking branch 'origin/feature/7144_new_v_conv_spectrum_axis'

Refs #7144 Conflicts:

Code/Mantid/Framework/TestHelpers/inc/MantidTestHelpers/WorkspaceCreationHelper.h

Changeset: bb6357fae43e1fea9810d16b0387ef8b2997f2a3

[Arturs Bekasovs]

Compared the Slice Views of the original workspace and converted one, noticed the difference in axis. Run the Python script provided and checked that the values are corresponding to the ones expected.

[Stuart Campbell]

This ticket has been transferred to github issue ​7990