Ticket #7257 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Remove pdf calculators

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description (last modified by Peter Peterson) (diff)

Specifically:

  • NomadSoQCalculator
  • NomadPDFCalculator
  • PowgenSoQCalculator
  • PowgenPDFCalculator
  • scripts/calpdf.py

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Description modified (diff)

comment:2 Changed 7 years ago by Peter Peterson

Notes on what was discovered in reviewing the scripts before deleting them:

  1. in NomadPDFCalculator it fits a region in Q with a + b*Q**2 + c*Q**4 and subtracts it off from the whole range of the data
  2. in NomadPDFCalculator it fits the high-Q portion of the data with a constant determined from the scattering lengths

comment:3 Changed 7 years ago by Peter Peterson

Re #7257. Removing deprecated scripts.

Changeset: cb6f168422bc91a04a42cb64193629f3710d24cd

comment:4 Changed 7 years ago by Peter Peterson

  • Status changed from new to accepted

comment:5 Changed 7 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

This is on ​feature/7257_remove_pdf_calculators.

To test: see that 5 files were deleted.

comment:6 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:7 Changed 7 years ago by Karl Palmen

NomadSoQCalculator NomadPDFCalculator PowgenSoQCalculator PowgenPDFCalculator found inPythonAPI/PythonAlgorithms in master before merging the change. Also scripts/calpdf.py found before merging the change.

comment:8 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

After merging the change, the py files of these scripts have gone.

comment:9 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8103

Note: See TracTickets for help on using tickets.