Ticket #7282 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Threshold MD always copies data, use in place changes if possible

Reported by: Nick Draper Owned by: Owen Arnold
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description (last modified by Owen Arnold) (diff)

Using the fly dataset the memory use peaks at 30GB (double the datasets 16GB) even when overwriting the original dataset. Also this leads to a long delay before the algorithm progress starts.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to accepted
  • Description modified (diff)

comment:2 Changed 7 years ago by Owen Arnold

Tester: The following should show these inplace operations working.

Show the original data.

CreateMDHistoWorkspace(SignalInput='1,2,3,4,5,6,7,8,9',ErrorInput='1,1,1,1,1,1,1,1,1',Dimensionality='2',Extents='-1,1,-1,1',NumberOfBins='3,3',Names='A,B',Units='U,T',OutputWorkspace='demo')
plotSlice('demo')

Threshold in place.

CreateMDHistoWorkspace(SignalInput='1,2,3,4,5,6,7,8,9',ErrorInput='1,1,1,1,1,1,1,1,1',Dimensionality='2',Extents='-1,1,-1,1',NumberOfBins='3,3',Names='A,B',Units='U,T',OutputWorkspace='demo')
plotSlice('demo')
ThresholdMD(InputWorkspace='demo',Condition='Greater Than',ReferenceValue='1',OverwriteWithZero='0',OutputWorkspace='demo')
plotSlice('demo')

Also try this out on the fly.vtk dataset if you can, as this was mentioned in the ticket description.

Last edited 7 years ago by Owen Arnold (previous) (diff)

comment:3 Changed 7 years ago by Owen Arnold

refs #7282. Modify in place and fix warnings.

Changeset: 3767e380bb1293d378212a477671f6110c8ee73f

comment:4 Changed 7 years ago by Owen Arnold

refs #7282. Comply with OpenMP restriction on windows.

Changeset: f576c82aabcc2358877058bb5a08f5190e3c9d11

comment:5 Changed 7 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:7 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

works well, does not use any additional memory when thresholding in place and is much fater for it.

comment:8 Changed 7 years ago by Nick Draper

  • Component changed from VATES to Framework

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8128

Note: See TracTickets for help on using tickets.