Ticket #7362 (closed: fixed)
Allow user to specify detector ID in EditInstrumentGeometry
| Reported by: | Wenduo Zhou | Owned by: | Peter Peterson |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.6 |
| Component: | Framework | Keywords: | |
| Cc: | petersonpf@… | Blocked By: | |
| Blocking: | #7336, #7364 | Tester: | Russell Taylor |
Description (last modified by Wenduo Zhou) (diff)
Currently EditInstrumentGeometry generates a detector ID for each spectrum by its own decision. Add a property such that user can specify the detector IDs of each spectrum.
Attachments
Change History
comment:5 Changed 7 years ago by Wenduo Zhou
How to verify
- Locate data file PG3_4844_event.nxs.
- Download script ticket7362.py.
- Run the script in Mantid. With user specified detector IDs, the high resolution TOF workspace and low resolution TOF workspace can be conjoined.
comment:8 Changed 7 years ago by Peter Peterson
Re #7362. Added validateInputs to the top.
Also re-arranged a bunch of other code. Part of the "clean-up" that Wenduo had mentioned.
Changeset: a21387bb9358dace0841086d46ff7f41634fc7e1
comment:9 Changed 7 years ago by Peter Peterson
Re #7362. Finished making some parameters optional.
Changeset: 1bd6091dfcb316e1f393da3f891eaba1f1abbfa4
comment:10 Changed 7 years ago by Wenduo Zhou
Checkpointing work. Refs #7362.
- Continue to cleaning codes by removing some legacy which is not used
now;
- Removing properties NewInstrument by merging it to InstrumentName
Changeset: 26800470ef072f7a19066b19c588fd17f9ceb7a4
comment:11 Changed 7 years ago by Wenduo Zhou
Finished cleaning codes. Refs #7362.
Changeset: 235c751feaa0bab52ff35a7b9d1a1e26afba709a
comment:12 Changed 7 years ago by Wenduo Zhou
- Status changed from accepted to verify
- Resolution set to fixed
comment:13 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:14 Changed 7 years ago by Wenduo Zhou
Fixed some possible memory leakages. Refs #7362.
Changeset: 0323c0e3def991e99800bac130ed2a152b144221
comment:16 Changed 7 years ago by Russell Taylor
Oh dear - this broke a system test because of the removal of the 'NewInstrument' property. See #7402.
comment:17 Changed 7 years ago by Andrei Savici
Wiki still contains reference to NewInstrument
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8208
Fixed the issue. Refs #7362.
Changeset: dcc47151c187f08de8f2ad470d6e9cdcd5b1596a