Ticket #7572 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Setting fitting parameters from the IDF doesn't work in scripts

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: critical Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description


Change History

comment:1 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to inprogress

Re #7572. Store workspace as a property of a domain.

This allows Fit to pass the workspace(s) to functions.

Changeset: 7ff839bd4ddaaee466e82d5e0a642482c8ada505

comment:2 Changed 7 years ago by Roman Tolchenov

Call setMatrixWorkspace for all 1d functions. Re #7572

Changeset: 16c419e27c814a1d86240205ab6a872f6db989de

comment:3 Changed 7 years ago by Roman Tolchenov

Call setMatrixWorkspace for all 1d functions. Re #7572.

Changeset: a1377b17f74183643d83d88a2b738e27fe1a4e8c

comment:4 Changed 7 years ago by Roman Tolchenov

Added the unit test. Re #7572.

Changeset: 39c747b93f95508ccc3d1bf52167037594d153c2

comment:5 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester:

The branch is bugfix/7572_instrument_fitting_parameters_2

The following script must not fail: 

hrp=Load('HRP38692a.nxs')
f='name=BackToBackExponential,I=8000,X0=26340.778;name=LinearBackground'
Fit(f,'hrp',WorkspaceIndex=4,StartX=24810.5,EndX=28140.1,Output='res')

The result must look OK.

Parameters f0.A and f0.B must have 0 errors as they must be fixed.

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:7 Changed 7 years ago by Nick Draper

fit suggested works, parameters fixed correctly, moving the parameters out shows a pretty robust fit.

Some issues found for the next release, but not introduced here.

comment:8 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/7572_instrument_fitting_parameters_2'

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8417

Note: See TracTickets for help on using tickets.