Ticket #7600 (closed: fixed)
Defect on SANS2D adding data
| Reported by: | Gesner Passos | Owned by: | Gesner Passos |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 3.0 |
| Component: | SANS | Keywords: | PatchCandidate |
| Cc: | anders.markvardsen@…, richard.heenan@… | Blocked By: | |
| Blocking: | Tester: | Samuel Jackson |
Description
Go to AddRuns using SANS2D instrument, add the following data:
19675, 19682, 19689 and sum them up.
Load the resulted file: SANS2D00019675-add.nxs or SANS2D00019689-add.nxs (depending on the order you have summed them), and open the instrument view on the generated workspace.
You will get the wrong image as in the attachment.
Attachments
Change History
Changed 7 years ago by Gesner Passos
- Attachment SANSadd_standalone.py added
The correct data was created using this script.
comment:7 Changed 7 years ago by Gesner Passos
Tester:
Run the SANSadd_standalone.py to create the SANS2D00019689-add.nxs file (rename this file) Than, add the three files 19675, 19682, 19689 using the SANS Add runs interface.
They should be almost equal (because one use the histogram and the other the event data). The CheckWorkspace will not pass.
Usually, the practice is to reduce the data using both files. You can take systemtests/Data/SANS2D/MASKSANS2D.091A as mask file.
The reduced data must be almost the same.
You can open the instrument view to see that it is now different from the attached one.
comment:8 Changed 7 years ago by Gesner Passos
Correct the indexes SANSadd2.py
The event data has the monitors in its head. Now, it copies the corresponded values.
re #7600
Changeset: 7884ac7a21e1183f9d7fae7d6b8afc5858b3af0e
Changed 7 years ago by Gesner Passos
- Attachment Adding_SANS2d.pdf added
This was the result before (reported by the user)
comment:9 Changed 7 years ago by Gesner Passos
Correction from user on how to test this ticket:
The nice Bragg rings in these data sets will likely only be seem if you use the related mask file, with the correct beam centre, attached, which then needs the two direct beam files also attached. The data in the three files is slightly different since they were collected at different temperatures. The histogram from the added workspace ought to give the same reduce I(Q) the same regardless of the route taken to add the files (adding three histograms, or adding three event files, then converting the result to histogram).
Use the attached files to reduce.
comment:11 Changed 7 years ago by Gesner Passos
- Status changed from inprogress to verify
- Resolution set to fixed
comment:12 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:13 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to verify
- Tester Roman Tolchenov deleted
comment:14 Changed 7 years ago by Samuel Jackson
- Status changed from verify to verifying
- Tester set to Samuel Jackson
comment:15 Changed 7 years ago by Samuel Jackson
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/7600_sans2d_add'
comment:16 Changed 7 years ago by Gesner Passos
Correct the indexes SANSadd2.py
The event data has the monitors in its head. Now, it copies the corresponded values.
re #7600 (cherry picked from commit 7884ac7a21e1183f9d7fae7d6b8afc5858b3af0e)
Changeset: a1af1e7b8082cdaf8b23c54220ca0f68ba81530c
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8445
