Ticket #7635 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add run_number log to event data if it is available

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: major Milestone: Release 3.0
Component: Framework Keywords:
Cc: martyn.gigg@… Blocked By:
Blocking: #6530 Tester: Jay Rainey

Description

LoadEventNexus could add the run_number log if it is available inside the file. This will make easier dealing with the reduction in SANS2D that has histogram and event data (in transition). LoadNexus provides the run_number (current being used inside the reduction) the LoadEventNexus could do as well.

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress
  • Blocking 6530 added

comment:2 Changed 7 years ago by Gesner Passos

In fact, SNS workspaces already have the run_number associated to the event workspaces. 

ws = Load('EQSANS_1466_event.nxs')
print ws.getRun()['run_number'].value

comment:3 Changed 7 years ago by Gesner Passos

ISIS does not have because the type of run_number is different among ISIS and SNS. At SNS string is used while in ISIS int is used.

comment:4 Changed 7 years ago by Gesner Passos

  • Cc martyn.gigg@… added

comment:5 Changed 7 years ago by Gesner Passos

Correct loading run_number to support int data type as in ISIS

re #7635

Changeset: 8a05800ce01d0710efede1a10665379650d418d1

comment:6 Changed 7 years ago by Gesner Passos

Tester: correct XXX to point to the archive for SANS data. 

ws = Load('XXX/ndxsans2d/Instrument/data/cycle_12_3/SANS2D00016183.nxs'')
print ws.getRun()['run_number'].value

It must provide back the run_number.

comment:7 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:8 Changed 7 years ago by Gesner Passos

  • Blocking 7600 removed

comment:9 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:10 Changed 7 years ago by Jay Rainey

Outputs the run_number as expected (verified by checking inside the files that I select for testing. To ensure the output run_number was correct).

Last edited 7 years ago by Jay Rainey (previous) (diff)

comment:11 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7635_run_number_log'

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8480

Note: See TracTickets for help on using tickets.