Ticket #7714 (closed: fixed)
Create a unit test for BSpline function
| Reported by: | Roman Tolchenov | Owned by: | Roman Tolchenov |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #7570 | Tester: | Samuel Jackson |
Description
BSpline was added for testing ticket #7623 in the GUI but it can be useful on its own.
Change History
comment:2 Changed 7 years ago by Samuel Jackson
- Blocking 7570 added
(In #7570) Update
After discussing the problem with Roman this ticket would probably best be solved by swapping out the CubicSpline function for BSpline due to efficiency issues. Therefore we should wait until either me or Roman write a unit test to verify BSpline works properly before changing SplineSmoothing.
comment:4 Changed 7 years ago by Roman Tolchenov
- Status changed from new to inprogress
Re #7714. Added unit tests for BSpline. Fixed issues.
Changeset: 3ff26d19915c2e8fe5da7f6ca8af1bfa1dac463a
comment:5 Changed 7 years ago by Roman Tolchenov
Re #7714. Added checks for invalid inputs for attributes.
Changeset: 3b25330477e5f9ab8f0ae941dab125ed3eebe90b
comment:6 Changed 7 years ago by Roman Tolchenov
- Status changed from inprogress to verify
- Resolution set to fixed
comment:7 Changed 7 years ago by Samuel Jackson
- Status changed from verify to verifying
- Tester set to Samuel Jackson
comment:8 Changed 7 years ago by Samuel Jackson
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7714_bspline_unit_test'
Full changeset: a24b9e6dd496d3ded0cd8abd099afe3efd3563cf
comment:9 Changed 7 years ago by Samuel Jackson
Ran the test locally and it passes. Code looks good too.
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8559
Heads up: as part of testing ticket #7623 I found I could cause a seg fault with BSpline by entering a negative value for the number of breakpoints in the fit browser. A BoundedValidator would probably fix this just fine.