Ticket #7788 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Implement algorithm FitPeak

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: critical Milestone: Release 3.0
Component: Framework Keywords:
Cc: petersonpf@…, lynchve@… Blocked By:
Blocking: #7789 Tester: Vickie Lynch

Description

Implement an algorithm named 'FitPeak' to fit a single peak with certain information. It should be refactored from the part to do the work to fit peak from algorithm FindPeaks

Change History

comment:1 Changed 7 years ago by Wenduo Zhou

  • Blocking 7789 added

comment:2 Changed 7 years ago by Wenduo Zhou

  • Cc lynchve@… added
  • Status changed from new to inprogress
  • Milestone changed from Backlog to Release 3.0

comment:3 Changed 7 years ago by Wenduo Zhou

Started to implement the algorithm. Refs #7788.

Changeset: 99885f0726f1d2b8109f6fbf7054ba256e598e35

comment:4 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Changeset: e76d19ccf5eace17fcd0de88a0711febe96fdf5c

comment:5 Changed 7 years ago by Wenduo Zhou

Added type IBackgroundFunction_sptr. Refs #7788.

Changeset: 2c8e6afd57545364ae29d3836d01382f30debb17

comment:6 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Changeset: b37859561c5f1bc0a1f3855a0a6a72a6242d161d

comment:7 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Changeset: 4439d159754fb6a6ce845216ec7796329e3b4eb7

comment:8 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Changeset: 64a32c24e44f72ae0cb51432fd2813eb30eb7aff

comment:9 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Changeset: e8a016fddde1197cf7c1312d0242a02cb5808c9b

comment:10 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Started to implement a Fit on multi-domain function (background)

Changeset: 4d6893e1648c39aad83f47994fa8c6fc15362f66

comment:11 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Changeset: 79180bd513db728221bed250d982d3ba896364f8

comment:12 Changed 7 years ago by Wenduo Zhou

Corrected some coding errors. Refs #7788.

Changeset: b5f7cdc89221a91da0db6889eb98989b2a3873e2

comment:13 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Changeset: 1c165d5d5097809a5a4a91f114828cd580c33bf1

comment:14 Changed 7 years ago by Wenduo Zhou

Fixed bugs during running unit test (unfinished). Refs #7788.

Changeset: d7381c672a1abd8bdd02d6e2c0664cadcb56ea1d

comment:15 Changed 7 years ago by Wenduo Zhou

Fixed bugs in fit peak. Refs #7788.

Changeset: 41cfb71a61d4f47633638a0c69f1fb7a16d164b4

comment:16 Changed 7 years ago by Wenduo Zhou

Fixed some compiling errors. Refs #7788.

Changeset: bbedfb15ad6eff24809f12b483729dae9677421f

comment:17 Changed 7 years ago by Wenduo Zhou

Progress on finish output data. Refs #7788.

Changeset: 07d9952028c5d89f919cc35d9a5f81ec2005cda7

comment:18 Changed 7 years ago by Wenduo Zhou

Started to implement the algorithm. Refs #7788.

Changeset: a428c75584c99fcfba2063a220ecc9165019ae3c

comment:19 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Changeset: edd75a01dcb99f37dfd6e45a38beea49aea38758

comment:20 Changed 7 years ago by Wenduo Zhou

Added type IBackgroundFunction_sptr. Refs #7788.

Changeset: b7068944239833740f9a50b9e6b985a801b178a5

comment:21 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Changeset: 53ef679da55f5b6fc35b1e2e15355612ba65b317

comment:22 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Changeset: 34fb2c6531c447ab07507d89bc811ba8172148e9

comment:23 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Changeset: 78c99c7a3ae0735ba4ff33cab1cfbcd456698a49

comment:24 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Changeset: 4bed9680ac44d06ec1feaec6f793c37190a3af09

comment:25 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Started to implement a Fit on multi-domain function (background)

Changeset: 3eafbb41c86e8dac295a33a833b22a6fb87718b7

comment:26 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Changeset: aac351eb8f1a878a7092a87f42f19e782343baf1

comment:27 Changed 7 years ago by Wenduo Zhou

Corrected some coding errors. Refs #7788.

Changeset: 9d1d1ada20cde7324aa555ca41da6280f5a466c3

comment:28 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #7788.

Changeset: 69acb456dbe07430a676eb080ba46b72e5616ba4

comment:29 Changed 7 years ago by Wenduo Zhou

Fixed bugs during running unit test (unfinished). Refs #7788.

Changeset: d440c1eeb759967abfd7cd07421e1d10e324e897

comment:30 Changed 7 years ago by Wenduo Zhou

Fixed bugs in fit peak. Refs #7788.

Changeset: 2cd6196e7a1a6f09426d543bbf9d6f1e72fadf31

comment:31 Changed 7 years ago by Wenduo Zhou

Fixed some compiling errors. Refs #7788.

Changeset: 8b8339baaa24169908a787964e1772c06c8cb366

comment:32 Changed 7 years ago by Wenduo Zhou

Progress on finish output data. Refs #7788.

Changeset: e281412f8784859b2b6b4eee55558f9051513f45

comment:33 Changed 7 years ago by Wenduo Zhou

Removed some unused code. Refs #7788.

Changeset: 42335eada5d46e5f4bf0ace23984c5db1e6ab273

comment:34 Changed 7 years ago by Wenduo Zhou

Modified some properties. Refs #7788.

Changeset: a3fa5db6d55a102c4c29ec91a3e90036f6139d9a

comment:35 Changed 7 years ago by Wenduo Zhou

Use multidomain in FitBackground. Refs #7788.

Changeset: 70192b43ead62aee83b35f0db017088e7efd5b15

comment:36 Changed 7 years ago by Wenduo Zhou

Tried to fit background with multidomain. Refs #7788.

Changeset: 76422a569d4c30eb05c72b2b64b90882c3031a50

comment:37 Changed 7 years ago by Wenduo Zhou

Fixed some error. Refs #7788.

Changeset: fa92fb12f372b655d0cd7e5700ff06a4b88f86dc

comment:38 Changed 7 years ago by Wenduo Zhou

Resolved the conflict. Refs #7788.

Changeset: 39ba8fc7660643657610eff05ae8edbea657b22c

comment:39 Changed 7 years ago by Wenduo Zhou

Updated multidomain function call. Refs #7788.

Changeset: dd12fe12e7d93e311139691093094334ecc27f54

comment:40 Changed 7 years ago by Wenduo Zhou

Fixed some bug in fit with 1 step. Refs #7788.

Changeset: 8bbc799662a65be51db38de088db95f2301c2416

comment:41 Changed 7 years ago by Wenduo Zhou

Added 1 more unit test. Refs #7788.

Changeset: 0a32556326cc1cdcf42b7d55a760619ddc8532dc

comment:42 Changed 7 years ago by Wenduo Zhou

Cleaned up the codes. Refs #7788.

Changeset: 0e0de5ef067fa9de58416fa6903b4936b67563b0

comment:43 Changed 7 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

For tester

Currently FitPeak works well on Gaussian. Tester can pick up any case.

Input for function

For Gaussian, the input vector of peak parameter names (strings) should be PeakCentre, Height and Sigma. It is case sensitive. The parameter names for background should be A0, A1 and A2. A1 and A2 are only applied to Linear or Quadratic.

comment:44 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:45 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/7788_fit_peak'

Full changeset: 4a844a2a8c64349cc780e7c02b6c0eab8dc25348

comment:46 Changed 7 years ago by Vickie Lynch

Fits my profile data well for both Gaussian and BackToBackExponential. In other tickets fix table names for backgroundintercept and Rwp.

comment:47 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8633

Note: See TracTickets for help on using tickets.