Ticket #7790 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Correct fitting parameter mistake in GEM_Parameters.xml

Reported by: Mike Thomas Owned by: Mike Thomas
Priority: major Milestone: Release 3.0
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Erroneous code places attribute 'result-unit' in element <parameter> instead of <formula>. Results in incorrect fitting of bank 4 data when using dspacing. The correction has been made and code will be commited.

Wrong code:

<component-link name="bank4" >

<parameter name="IkedaCarpenterPV:SigmaSquared" type="fitting">

<formula eq="176.833*centre2" unit="dSpacing" result-unit="TOF2"/>

</parameter> <parameter name="IkedaCarpenterPV:Gamma" type="fitting" result-unit="TOF">

<formula eq="4.416*centre" unit="dSpacing"/>

</parameter>

</component-link>

Corrected Code:

<component-link name="bank4" >

<parameter name="IkedaCarpenterPV:SigmaSquared" type="fitting">

<formula eq="176.833*centre2" unit="dSpacing" result-unit="TOF2"/>

</parameter> <parameter name="IkedaCarpenterPV:Gamma" type="fitting">

<formula eq="4.416*centre" unit="dSpacing" result-unit="TOF"/>

</parameter>

</component-link>

Change History

comment:1 Changed 7 years ago by Mike Thomas

  • Status changed from new to inprogress

Commit fixed GEM_Parameters Refs #7790

Changeset: 85e747e0357e9658d62734cfef347f835f4bb680

comment:2 Changed 7 years ago by Mike Thomas

  • Owner set to Anders Markvardsen

comment:3 Changed 7 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test: check that changed according to description

comment:4 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:5 Changed 7 years ago by Russell Taylor

  • Milestone changed from Backlog to Release 3.0

comment:6 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to verify
  • Tester Jay Rainey deleted

comment:7 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:8 Changed 7 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7790_fix_GEM_Parameters_fitting_error'

comment:9 Changed 7 years ago by Nick Draper

  • Owner changed from Anders Markvardsen to Mike Thomas

After the summer contact Anders Markvardsen about these tickets

comment:10 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8635

Note: See TracTickets for help on using tickets.