Ticket #7863 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Correct wrong api usage

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: major Milestone: Release 3.0
Component: Python Keywords:
Cc: Blocked By:
Blocking: #7690 Tester: Jay Rainey

Description

These files have a line mtd[ws] == None 

Mantid/scripts/Inelastic/IndirectEnergyConversion.py
Mantid/scripts/Inelastic/IndirectCommon.py

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Gesner Passos

  • type changed from enhancement to defect

comment:3 Changed 7 years ago by Gesner Passos

Correct the wrong usage of new api

change mtd[ws] == None to not mtd.doesExist(ws)

re #7863

Changeset: 213e34aaab78fc67b984d6832cf95042f966fbf1

comment:4 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test the change of the code in Code/Mantid/scripts/Inelastic/IndirectEnergyConversion.py,

just open Interface -> Indirect Diffraction.

If it opens, the code have been passed.

To test the change in IndirectCommon.py, you will have to execute a script like this one: 

from IndirectCommon import loadInst
l = loadInst('TOSCA')

comment:5 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:6 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/7863_inelastic_api'

comment:7 Changed 7 years ago by Jay Rainey

Indirect Diffraction opens as expected. I ran the provided script, and no errors occurred.

Having looked at the two changes they now abide by the new API.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8708

Note: See TracTickets for help on using tickets.