VSI Rebinner progress update mostly missing

[Michael Reuter]

When using the rebinner in the VSI the first time, the progress bar updates fine if a long rebin is going. However, subsequent usages do not show up unless the original axis configuration is put back. After that, the progress shows up again, but then further usage fails to work again. The progress bar should be updating all the time when necessary.

[Michael Reuter]

Refs #7931. Removing offending line of code.

After much searching, it turns out that resetting the display first causes the disruption of progress updating. Doesn't make sense, but there it is.

Changeset: 6adc0309aaeee5c9e7c5d2ab3dfc420bfb795201

[Michael Reuter]

The branch is ​here.

To test: This one requires access to large (> 1.5GB) MD dataset, or one that can take a fine step size in the axes. The rebinning process needs to be long enough to show updates to the progress bar. One should make sure to do the following before applying the fix:

1. Open the file in Mantid and then plot in the VSI
2. Click the Rebin button
3. Configure a rebinning and click Apply
4. Configure a second rebinning and click Apply

Before the fix, the second rebinning will not cause the progress bar to update. You can try a third if you want. After the fix, the progress bar should update all the time.

[Owen Arnold]

Hmm, it appears that I neither get progress updating before or after your changes on the Mac. I think this is a separate issue. I'll give these changes a go on windows before and after.

[Michael Reuter]

I also see that ParaView is not updating the progress bar at all for the rebinner plugin on Mac. Looks like the Mac is a ParaView problem.

[Owen Arnold]

I agree with above comment, this is likely to be a paraview issue.

Unfortunately these changes don't seem to fix the issue on Windows. Still get no progress update on the 2nd rebin, even though I do on the first.... I may need to reopen this ticket.

[Michael Reuter]

Hmm, so Windoze wants something else. I checked ParaView on Windows and the progess bar updates fine all the time. I'll dig further. Sigh.

[Michael Reuter]

Refs #7931. Attempting to fix Windoze.

I ran this on Linux first to see if anything broke. Looks to be fine, so I'll try Windows now.

Changeset: 442229573708180a899a335e0698fba48da51e4b

[Michael Reuter]

Refs #7931. Clean up and documenting code.

Changeset: 4a579d85ad83b4b706b0abb353b890d19ce335d8

[Michael Reuter]

Test as before on Linux and Windoze. Mac is broken all around and will be addressed separately (#7951).

[Owen Arnold]

Merge remote-tracking branch 'origin/bugfix/7931_vsi_rebinner_progress'

[Stuart Campbell]

This ticket has been transferred to github issue ​8776