Ticket #7953 (closed: fixed)
Make MultipleScatteringCylinderAbsorption event aware
| Reported by: | Peter Peterson | Owned by: | Peter Peterson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #7987 | Tester: | Michael Reuter |
Description (last modified by Peter Peterson) (diff)
This is the first step in a real push to get absorption corrected for in mantid.
Attachments
Change History
comment:4 Changed 7 years ago by Peter Peterson
- Description modified (diff)
Moved some of the work to a new ticket to make this easier to verify.
comment:5 Changed 7 years ago by Peter Peterson
Re #7953. Using SetSampleMaterial to clarify things.
Changeset: aa4a9c58fca26806ce079f3935cb756cbc454178
comment:6 Changed 7 years ago by Peter Peterson
Re #7953. Adding more logging and fixing but in absorptionXS get.
Changeset: 1035c29ba18d38b04e0e728d9c2fa9d0a2c0ca33
comment:7 Changed 7 years ago by Peter Peterson
Re #7953. Quieting compiler warning.
Changeset: 8058fd6973337ad43584325d8ea27c25968edb1a
comment:8 Changed 7 years ago by Peter Peterson
Re #7953. Changed variable name to reflect actual value.
Changeset: f4b2105f63683d21655589ba0a609899e7890c27
comment:9 Changed 7 years ago by Peter Peterson
Re #7953. Made MultScatt... event aware.
Changeset: 555f0b79523a4a1373152d7b387f00ae76960108
comment:10 Changed 7 years ago by Peter Peterson
Re #7953. Moved implementation from header to source.
Changeset: 71482bf3e847d554115e38b513d46437b4333a07
comment:11 Changed 7 years ago by Peter Peterson
Re #7953. Added in progress bar reporting.
Changeset: 02fc1bfe14e096ac45caa26a5e4877db8e7777e6
comment:12 Changed 7 years ago by Peter Peterson
This is on feature/7953_MultipleScatteringCylinderAbsorption.
To test: Run the attached script and compare the various reductions.
comment:13 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:14 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:15 Changed 7 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution fixed deleted
This needs a unit test for the events.
comment:16 Changed 7 years ago by Peter Peterson
- Status changed from reopened to inprogress
Re #7953. Adding unit test for the event case of MultScattCylAbs...
Really easy case to pass. Mostly just confirms that you get an event workspace back. Since the math is the same between both event and histo rely on the histogram to keep the calculation correct.
Changeset: 3e7645ee40c9db421e91050e30694bd7ca0d22fc
comment:17 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
Same testing regiment as mentioned in comment:12.
comment:19 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7953_MultipleScatteringCylinderAbsorption'
comment:20 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8798
