Ticket #7971 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

make centre optional for sphere shape

Reported by: Anders Markvardsen Owned by: Peter Parker
Priority: major Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #7940, #7970 Tester: Samuel Jackson

Description

<sphere id="A">

<centre x="4.1" y="2.1" z="8.1" /> <radius val="3.2" />

</sphere>

make centre optional and default to (0,0,0)

Change History

comment:1 Changed 7 years ago by Peter Parker

  • Status changed from new to inprogress

Refs #7971 - Allow default centre for Sphere shapes.

Plus add unit test.

Changeset: 3cc0ff36dcf8f76e4baa41fb62e760bb17f25404

comment:2 Changed 7 years ago by Peter Parker

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Milestone changed from Backlog to Release 3.0

comment:3 Changed 7 years ago by Peter Parker

Tester:

This is a simple ticket, so shouldn't require too much testing. Make sure that you can define circle shapes in IDF files without using the centre field, and that (0,0,0) is the default value in this case. Make sure the changes look reasonable.

Instructions about IDFs for the uninitiated:

comment:4 Changed 7 years ago by Peter Parker

  • Blocking 7940, 7970 added

This ticket contains getOptionalShapElement(), which is required by two other tickets.

comment:5 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:6 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7971_make_centre_optional_for_sphere_shape'

Full changeset: ​8be5c4d9eb35ca250d2eea86998e25e6c1b1c968

comment:7 Changed 7 years ago by Samuel Jackson

Tested this by using LoadEmptyInstrument and playing around with Instrument view. The IDF seems to respond fine when omitting the sphere centre definition.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8816

Note: See TracTickets for help on using tickets.