Ticket #8025 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Get old performance on WishAnalysis system test back

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.0
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

A side effect of closing #7797 is that WishAnalysis ​slowed down significantly. See if there is a way to get the performance back without re-introducing the error fixed by #7797.

Attachments

SystemTests.WishAnalysis.WishAnalysis.runtime.v.revision.ALL.png​ (37.3 KB) - added by Russell Taylor 7 years ago.
Figure showing the degradation and subsequent recovery

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

Re #8025. Fixing logic in CreateGroupingWorkspace.

This was configuring the grouping workspace twice if the user specified loading it from a file. That was the source of the performance hit.

Changeset: 1cbd12395e67108b12f174b617d19ae3fe29f2ff

comment:2 Changed 7 years ago by Peter Peterson

Re #8025. Moving code from header to source.

Changeset: bf37e9e89a4a280db2ea9bea9f6324143355e669

comment:3 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is on ​bugfix/8025_wish_performance.

To test: Look at how much the offending system test has been sped up.

comment:4 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:5 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/8025_wish_performance'

Changed 7 years ago by Russell Taylor

Figure showing the degradation and subsequent recovery

comment:6 Changed 7 years ago by Russell Taylor

Didn't quite get back to the old timing, but close.

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8870

Note: See TracTickets for help on using tickets.