Ticket #8032 (closed: fixed)
Mantid dock loses selection after update
| Reported by: | Roman Tolchenov | Owned by: | Roman Tolchenov |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.0 |
| Component: | GUI | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Arturs Bekasovs |
Description
Attachments
Change History
comment:2 Changed 7 years ago by Roman Tolchenov
- Status changed from inprogress to verify
- Resolution set to fixed
To tester:
Actually the attached script isn't needed to test this ticket.
Load a couple of workspaces, then select some of them in the dock widget. Run an algorithm or a script which creates/deletes workspaces. See that the selected workspaces remain selected. Check that it works with groups as well.
comment:3 Changed 7 years ago by Arturs Bekasovs
- Status changed from verify to verifying
- Tester set to Arturs Bekasovs
comment:4 Changed 7 years ago by Arturs Bekasovs
- Status changed from verifying to reopened
- Resolution fixed deleted
Checked that problem exists on previous version. Seems to be fixed by the changes made.
Tested using various Workspace types and groups and selection is not lost. Works properly when one of the selected items gets modified.
However, selection is lost when selected item gets renamed. To reproduce:
- Load some workspaces.
- Select a couple.
- Rename one of those you selected. The workspace with new name is not selected any more.
Roman suggested that this is worth fixing, so re-opening the ticket.
comment:5 Changed 7 years ago by Arturs Bekasovs
- Tester Arturs Bekasovs deleted
I will be away next Friday, so returning to the testing pool for somebody else to verify it.
comment:6 Changed 7 years ago by Roman Tolchenov
- Status changed from reopened to inprogress
Track renaming in the ADS to keep selection in the dock. Re #8032
Changeset: ded308c2e2f4dfa51d3882cc5f8f0c6011c08ed7
comment:7 Changed 7 years ago by Roman Tolchenov
- Status changed from inprogress to verify
- Resolution set to fixed
comment:8 Changed 7 years ago by Arturs Bekasovs
- Status changed from verify to verifying
- Tester set to Arturs Bekasovs
comment:9 Changed 7 years ago by Arturs Bekasovs
Works correctly now. Renaming workspace doesn't un-select it.
There is another corner case found when workspaces might get un-selected: if we rename ws1 to ws2 when both ws1 and ws2 are selected. But this case seems to be extremely rare and it's quite difficult to assume what users expect to happen in that case.
All in all, the goal of the ticket is achieved, hence I am closing it.
comment:10 Changed 7 years ago by Arturs Bekasovs
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/8032_dock_loses_selection'
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8877
Restore selection after dock updates. Re #8032
Changeset: ec1ade8834fae7d1b1c00c24a3269df0abb4a0d8