Ticket #8073 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SaveGSASInstrumentFileTest does not check file existence properly

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: major Milestone: Release 3.1
Component: Framework Keywords: maintenance
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

I've found that this unit test fails on my machine. I found out it fails because it tests the existance of a file it has created using just the name of the file rather than the full path name as is done in other unit tests.

The file existence test should be on the full filepath, which can be obtained by getting the property "OutputFilename" as is done in many other unit tests.

Change History

comment:1 Changed 7 years ago by Karl Palmen

  • Owner set to Karl Palmen

comment:2 Changed 7 years ago by Karl Palmen

  • Milestone changed from Backlog to Release 3.1

comment:3 Changed 7 years ago by Karl Palmen

  • Status changed from new to inprogress

comment:4 Changed 7 years ago by Karl Palmen

Make SaveGSASInstrumentFileTest.h use full pathname re #8073

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 668060b98b72380a34e373f9e75415cf5d49dd49

comment:5 Changed 7 years ago by Karl Palmen

Also make the change to a disabled test re #8073

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: c575f147b2a4d60f8dade56ab03bc30e1e65564d

comment:6 Changed 7 years ago by Karl Palmen

Hopefully fix an illegal string operation tolerated by Windows re #8073

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 66ddd51c123cb81dca5997836b952403cba3e220

Last edited 7 years ago by Karl Palmen (previous) (diff)

comment:7 Changed 7 years ago by Karl Palmen

Fix a compiler warning re #8073

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9a5bd3a17f081e40439273d0bd04466fcf28a747

comment:8 Changed 7 years ago by Russell Taylor

There is an error at line 60 of SaveGSASInstrumentFileTest.h which is generating a compiler warning - there's a colon missing between std & string. The build is not failing because there's a "using namespace std" in the file and it's treating the std as a label.

comment:9 Changed 7 years ago by Karl Palmen

This is the compiler warnimng I fixed in the commit referred to in the previous comment 7.

comment:10 Changed 7 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test: Check that the unit test runs on your own computer and the code has been changed so the output file is referred to by the value got from getProperty, except for use in setProperty.

comment:11 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:12 Changed 7 years ago by Martyn Gigg

The warning has been fixed, the changes look sensible & the test passes for me too.

comment:13 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8073_check_file_existence'

Full changeset: ​131394c8e84051ca71b986e5d80ff3930b9a2337

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8918

Note: See TracTickets for help on using tickets.