Default values not displayed in comboboxes

[Martyn Gigg]

The following algorithm should generate a ComboBox on the algorithm dialog with "B" set as the default but it shows "A"

from mantid.kernel import *
from mantid.api import *

class PyAlg(PythonAlgorithm):
        
        def PyInit(self):
                self.declareProperty('Multiplier', 'B', StringListValidator(['A','B']), direction=Direction.Input, doc='Select the form of the invariant to calculate')
                
        def PyExec(self):
                pass
                
AlgorithmFactory.subscribe(PyAlg)

A related bug can be seen by using LoadRaw. This requires your old algorithm history to be deleted ($HOME/.config/Mantid/MantidPlot.conf on Linux, registry HKCU/Software/Mantid/MantidPlot on Windows). Click Load and navigate to a raw file. The "LoadMonitors" option should be set to Include by default, to match the algorithm, however Exclude is displayed.

This was reported by Steve King when trying to write a new Python algorithm.

[Martyn Gigg]

Fix generation of ComboBox on GenericDialog.

• The current value from the property needs to be set visible.
• The signal connection needs to come after the box is populated or

it keeps changing the property value as things are added in the loop

Refs #8086

Changeset: 60d3df4c5a05dac6c65638ca66f94fd5e37b593f

[Martyn Gigg]

Fix defaults for boolean options property dialog in LoadDialog.

Refs #8086

Changeset: 230490c8f3a54f177e9dc08fdbf12a52ed4461af

[Martyn Gigg]

Branch: bugfix/8086_alg_combobox_defaults

Tester: Use the instructions in the description to test the ComboBox options on a generic dialog & Load dialog separately. For the Load dialog test be sure to clear you cache of old algorithm histories first'''.

For both tests check that once set the property is remembered next time the algorithm is run.

[Owen Arnold]

This is indeed a problem in older version of Mantid.

[Owen Arnold]

This is now fixed. Code review looks good. I'm going to have to hold off merging this to master as can't connect to github at the moment. Hopefully will be able to do this this afternoon.

[Owen Arnold]

Merge remote-tracking branch 'origin/bugfix/8086_alg_combobox_defaults'

Full changeset: ​51378f50da4b9f1595cc81c5a2d6caf39d6aae26

[Stuart Campbell]

This ticket has been transferred to github issue ​8931