Ticket #8092 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Make FileEventDataListener handle event files

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 3.0
Component: GUI Keywords: LiveData
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

The FileEventDataListener should be able to handle event NeXus files as well as the current types of files. Restructure the code a bit to make this possible while being agnostic to the file name as much as possible.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Michael Reuter

Refs #8092. Making loader finding not depend on filename parsing.

Changeset: 334a60aa2dd51bb4c13d919ab17437411a39bf76

comment:3 Changed 7 years ago by Michael Reuter

Refs #8092. Whitespace fixes.

Changeset: 49871198f2b0a8d26fc6e4dadb2a3ad25b1433d3

comment:4 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch can be found here.

To test: Set the following properties in your Mantid.user.properties file:

  • fileeventdatalistener.filename
  • fileeventdatalistener.chunks

With a filename pointing to an event NeXus file. This can be done at SNS using the new ADARA (*.h5) NeXus files. You can also try Pre(Event)Nexus files as well, but the unit test covers one of those cases. Make sure the unit test works.

comment:5 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/8092_fileeventdatalistener_eventnexus'

Full changeset: 0f5c9623e688382e2d023993237c23215952853f

comment:7 Changed 7 years ago by Russell Taylor

  • Keywords LiveData added

As anticipated, the event build up in a pretty strange way for these files (a back at a time), which is why this originally targeted preNexus files. But since those are going away with ADARA, this change serves a purpose.

comment:8 Changed 7 years ago by Russell Taylor

P.S. I agree that no additional unit test is merited as this is itself essentially test code.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8937

Note: See TracTickets for help on using tickets.