Ticket #8209 (closed: fixed)
ICAT4 Datetime
| Reported by: | Jay Rainey | Owned by: | Jay Rainey |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.0 |
| Component: | GUI | Keywords: | ICAT,ICAT4 |
| Cc: | Blocked By: | #6457, #7637, #8126 | |
| Blocking: | Tester: | Arturs Bekasovs |
Description
The output of the start and end dates within the new GUI are correct, but do not appear with the correct investigation. In some cases the end date is lower than the start.
Change History
comment:2 Changed 7 years ago by Jay Rainey
The date-time are correctly added in the workspace created in the correct order. When adding to the GUI the end date is added to the wrong column, but are not added to the GUI correctly.
This occurred as I was performing a sort on the end-date column prior to adding data.
I will make the year in the investigation column date rows to appear first (year/month/day). This allows the sorting functionality to work as expected.
comment:3 Changed 7 years ago by Jay Rainey
- Status changed from new to inprogress
Fix ICAT datetime in GUI. Refs #8209.
- Sorting should happen only when data is in the table.
- Changed the format of dates to allow them to be sorted easier.
Changeset: 48835057c700007fbf3c3f8adaa423938bd9dd71
comment:4 Changed 7 years ago by Jay Rainey
- Status changed from inprogress to verify
- Resolution set to fixed
- Blocked By 6457 added
To verify that this now works correctly log into the catalog, and perform a search. The result table will be populated, and the end date is never larger than the start date, and that they generally make sense..
To check this is true you could log into the ICAT4 web-gui.
comment:6 Changed 7 years ago by Jay Rainey
- Blocked By 8126 added
This should not be tested until blocking tickets have been fixed.
comment:7 Changed 7 years ago by Jay Rainey
- Status changed from verify to reopened
- Resolution fixed deleted
I need to revert "%F" to "%d-%m-%y" as it's not supported on Windows!!
comment:8 Changed 7 years ago by Jay Rainey
- Status changed from reopened to inprogress
Use long form datetime. Refs #8209.
- %F is not supported on windows.
Changeset: fb2ff06fd1d3025e1a7444d9d4cbcb096abbda47
comment:9 Changed 7 years ago by Jay Rainey
To test
- Log into ICAT.
- Perform a search.
- Verify that the end date is not greater than the start date for any investigation, and verify that they are the correct start/end dates. To do this I recommend using the ICAT4.3 web interface TOPCAT.
comment:10 Changed 7 years ago by Jay Rainey
- Status changed from inprogress to verify
- Resolution set to fixed
comment:11 Changed 7 years ago by Arturs Bekasovs
- Status changed from verify to verifying
- Tester set to Arturs Bekasovs
comment:12 Changed 7 years ago by Jay Rainey
Sort by create time. Refs #8209.
Changeset: 2914fbb96eb6b7da0ff6178ee49c41a4f051f042
comment:13 Changed 7 years ago by Jay Rainey
Improve index being sorted. Refs #8209.
Changeset: 0797b93fe060a1cda5b23521fcf18107a0b22139
comment:14 Changed 7 years ago by Jay Rainey
- Status changed from verifying to reopened
- Resolution fixed deleted
- Tester Arturs Bekasovs deleted
comment:15 Changed 7 years ago by Jay Rainey
- Status changed from reopened to verify
- Resolution set to fixed
comment:16 Changed 7 years ago by Arturs Bekasovs
- Status changed from verify to verifying
- Tester set to Arturs Bekasovs
comment:17 Changed 7 years ago by Arturs Bekasovs
Able to reproduce the problem on the current master.
Code changes make sense - adding rows to sorted table might be tricky, as rows are moved around and pointers change during the process.
After the fixes made, seems to be solved. There is a minor issue with table sorting revealed, ticket for that - #8271.
comment:18 Changed 7 years ago by Arturs Bekasovs
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8209_icat_datetime_fix'
Full changeset: d025958dd04d84b91257822f4ee622c423960701
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9054
