Ticket #8225 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

QLines ResNorm option should be optional

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.0
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Parker

Description

Franz is reporting that the QLines option ResNorm should be optional. Make it so.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8225 Make ResNorm loading optional for QLines.

Changeset: 8866e011aad86fd8f16713bedbdbe7e292f33a75

comment:2 Changed 7 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.0

comment:3 Changed 7 years ago by Samuel Jackson

Refs #8225 Fix file processing for QLines.

Changeset: 7f926dc2e80516abf7997821aa28fd0ceed50211

comment:4 Changed 7 years ago by Samuel Jackson

To Tester

This ticket will need to be tested on Windows and built in Release Mode.

You only really need to check that running QLines works with and without a ResNorm file. You can use the two files irs26176_graphite002_red and irs26173_graphite002_res as input. There's also a resnorm_params file in the system tests data repo too.

For some default parameters I'd suggest just using:

  • Energy Min/Max: -0.5/0.5
  • Sample and Res binning: both 1
  • leave FixWidth unticked

comment:5 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:7 Changed 7 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8225_QLines_resnorm_opt'

Full changeset: ​4e818c707ad63bcd9f8330f8309b81c7f4561f82

comment:8 Changed 7 years ago by Peter Parker

The QLines algorithm now works with or without a ResNorm file specified.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9070

Note: See TracTickets for help on using tickets.