Ticket #8228 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

A limited fix to the issue in #6171

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.0
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

The issue is that when a workspace (stored in the ADS) is passed to an algorithm by shared pointer the history doesn't record the name of that workspace. The changes in ticket #6171 try to fix the problem in general but apparently made some system tests fail.

This ticket will fix the issue for Fit algorithm called by the fit browser.

Change History

comment:1 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to inprogress

Call Fit with workspace name instead of shared pointer in fit browser

Re #8228

Changeset: 2151b9077f3495c7eefa675443ac44c8961af6da

comment:2 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  1. Fit a spectrum in MantidPlot.
  2. Open the algorithm history dialog for one of the output workspaces.
  3. Generate a script.
  4. Run it, see that it works

comment:3 Changed 7 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:4 Changed 7 years ago by Wenduo Zhou

It works now.

comment:5 Changed 7 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8228_fit_history_from_fit_browser'

Full changeset: ​08980805ea9523d535fdaa3aa4f8681ae5d7202c

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9073

Note: See TracTickets for help on using tickets.