SaveIsawPeaks does not work on non-rectangular arrays

[Peter Peterson]

Pascal is trying to save peaks files from WISH and this algorithm cannot currently do it.

[Vickie Lynch]

Refs #8251 Everything in file but width and height for WISH

Changeset: 8179d5b8746426b5064ee710492cb9ec5cd640ee

[Vickie Lynch]

Refs #8251 output size of banks for WISH

Changeset: a51dcb9bd5bd656235650d11e055c6e139c2e916

[Owen Arnold]

This does seem to save OK, but I'm getting this error upon load.

There is no bank bank3 in the instrument
Error in execution of algorithm LoadIsawPeaks:
There is no bank bank3 in the instrument

Saving and loading the same peaks workspace as a nexus file works. I think that this functionality is not complete unless both Load and Save work correctly in the ISAW format.

[Vickie Lynch]

I have another ticket #8571 to fix LoadIsawPeaks for WISH. Could you close this one so I can do the other ticket? See blocking comment above.

[Owen Arnold]

Agreed.

[Wenduo Zhou]

During test, I encountered segmentation default.

Here is the message from gdb: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffc3ba7700 (LWP 9141)] 0x00007fffce70a890 in Mantid::Crystal::SaveIsawPeaks::findPixelPos(std::string, int, int) ()

from /home/wzz/Projects/MantidTests/VerificationTest/Mantid/Code/debug/binlibMantidCrystal.so

(gdb) bt

#0 0x00007fffce70a890 in Mantid::Crystal::SaveIsawPeaks::findPixelPos(std::string, int, int) ()

from /home/wzz/Projects/MantidTests/VerificationTest/Mantid/Code/debug/binlibMantidCrystal.so

#1 0x00007fffce70d75f in Mantid::Crystal::SaveIsawPeaks::exec() ()

from /home/wzz/Projects/MantidTests/VerificationTest/Mantid/Code/debug/binlibMantidCrystal.so

#2 0x00007ffff6facedc in Mantid::API::Algorithm::execute() () from /home/wzz/Projects/MantidTests/Mantid_2nd/Mantid/Code/debug/bin/libMantidAPI.so

#3 0x00007ffff6fa7764 in Mantid::API::Algorithm::executeAsyncImpl(Poco::Void const&) ()

from /home/wzz/Projects/MantidTests/Mantid_2nd/Mantid/Code/debug/bin/libMantidAPI.so

#4 0x00007ffff6fd0287 in Mantid::API::AlgorithmProxy::executeAsyncImpl(Poco::Void const&) ()

from /home/wzz/Projects/MantidTests/Mantid_2nd/Mantid/Code/debug/bin/libMantidAPI.so

#5 0x00007ffff6fd18e1 in Poco::ActiveRunnable<bool, Poco::Void, Mantid::API::AlgorithmProxy>::run() ()

from /home/wzz/Projects/MantidTests/Mantid_2nd/Mantid/Code/debug/bin/libMantidAPI.so

#6 0x00007ffff1fd6a97 in Poco::PooledThread::run() () from /usr/lib/libPocoFoundation.so.9

#7 0x00007ffff1fd4776 in Poco::ThreadImpl::runnableEntry(void*) () from /usr/lib/libPocoFoundation.so.9

#8 0x00007ffff0e02e9a in start_thread (arg=0x7fffc3ba7700) at pthread_create.c:308

#9 0x00007ffff0b2f3fd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:112

#10 0x0000000000000000 in ?? ()

The script that I used is Load(Filename=r'C:/Users/spu92482/Documents/mantiddata/paz_script_and_data/WISH00017720.raw',OutputWorkspace='WISH00017720') CropWorkspace(InputWorkspace='WISH00017720',OutputWorkspace='cropped17720',EndWorkspaceIndex='10000') AddSampleLog(Workspace='cropped17720',LogName='run_start',LogText='') AddSampleLog(Workspace='cropped17720',LogName='run_header',LogText='') AddSampleLog(Workspace='cropped17720',LogName='run_end',LogText='') AddSampleLog(Workspace='cropped17720',LogName='run_title',LogText='') AddSampleLog(Workspace='cropped17720',LogName='run_number',LogText='') Load(Filename=r'/home/wzz/Projects/MantidProjects/systemtests/Data/Wish_Diffuse_Scattering_A.nxs',OutputWorkspace='Wish_Diffuse_Scattering_A') ConvertToMD(InputWorkspace='Wish_Diffuse_Scattering_A',OutputWorkspace='Wish_Diffuse_Scattering_A_MD',QDimensions='Q3D',dEAnalysisMode='Elastic',MinValues='-5,-5,- 5',MaxValues='5,5,5',SplitInto='2',SplitThreshold='50') FindPeaksMD(InputWorkspace='Wish_Diffuse_Scattering_A_MD',OutputWorkspace='Wish_Peaks') SaveIsawPeaks(InputWorkspace="Wish_Peaks", Filename="/tmp/wish_peaks.peaks.")

[Vickie Lynch]

Refs #8251 for old geometry without numbered pixels

Changeset: 1f6465a81119051d3c37901c6489c503b6d04bc2

[Wenduo Zhou]

The Isaw peak file now can be saved from a Wish peak workspace.

[Wenduo Zhou]

Merge remote-tracking branch 'origin/feature/8251_SaveIsawPeaks_for_WISH'

Full changeset: ​c38ce722d8df7bf4d4b109060b80d74611475931

[Stuart Campbell]

This ticket has been transferred to github issue ​9096