At least one Tube Calibration Script does not work.

[Karl Palmen]

If found one of the example scripts in ...\mantid\Code\Mantid\scripts\Calibration\Examples did not work. It was TubeCalibDemoMaps.py and the PeakFile keyword was rejected there. This needs fixing or removing if no longer needed.

Also all other scripts need to be checked, if any do not work either fix or remove if no longer needed.

[Karl Palmen]

None of the example files remain in the git repository. They have been removed.

[Karl Palmen]

But there are examples in MantidInstall. I tried a new install and it put them there despite being removed from old install.

[Karl Palmen]

Examples have now appeared in my repository.

[Karl Palmen]

The examples in http://www.mantidproject.org/Tube_Calibration_Examples work if ran through the scriptlets quoted there.

[Karl Palmen]

The following example files were not run in the course of the previously mentioned example page (they have no .pyc file).

TubeCalibDemoMaps_B1.py, TubeCalibDemoMaps_C4C3.py, TubeCalibDemoMaps_C4C3C2.py, TubeCalibDemoMaps_D2.py, TubeCalibDemoMaps_D2_WideMargins.py, TubeCalibDemoMaps+D4.py, TubeCalibDemoMaps_Simple.py,

TubeCalibDemoMerlin_Adjustable.py, TubeCalibDemoMerlin_Simple.py,

TubeCalibDemoWish_5panels.py, TubeCalibDemoWish0.py, TubeCalibDemoWish1.py.

[Karl Palmen]

All MAPS scripts work.

[Karl Palmen]

TubeCalibDemoMerlin_Adjustable.py does not work correctly. The use of UsePeakFile boolean needs sorting out. Also numpy needs importing.

[Karl Palmen]

Import numpy in TubeCalibDemoMerlin_Adjustable.py re #8263

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: c14b6cccc6978bc0f14c0cb218f3dabea5602d3b

[Karl Palmen]

Import numpy in TubeCalibDemoMerlin_Simple.py re #8263

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: fa76bb339489f748bea0f406f8c9c44b0d837552

[Karl Palmen]

Remove TubeCalibDemoMerlin_Adjustable.py re #8263

This example is no longer needed. It demonstrated a withdrawn feature and was the example that no longer worked.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 6c88904377ada5be67b481d071481095a0db0c33

[Karl Palmen]

All scripts work, except TubeCalibDemoMerlin_Adjustable.py, which has been removed and TubeCalibDemoMerlin_Simple.py which has since had an import of numpy added. They should all work now.

[Karl Palmen]

To test, check that TubeCalibDemoMerlin_Adjustable.py has been removed and run any scripts that have been modified by this ticket (only one TubeCalibDemoMerlin_Simple.py).

You may also check the wiki http://www.mantidproject.org/Tube_Calibration and run other scripts if you wish.

[Keith Brown]

the merlin instrument failing the test

[Keith Brown]

couple of things: i tried to run TubeCalibDemoMerlin_Simple.py and couldn't find the file initially, the script didn't tell me where to find it. Ended up looking it up in the journals and found it in cycle_11_5, but a point in the right direction would have helped.

After finding the file, the script didn't work properly, as the instrument didn't look right afterwards, see the image I attached

[Karl Palmen]

TubeCalibDemoMerlin_Simple.py could be removed having been superceded by TubeCalibDemoMerlin.py, if it can't be fixed easily.

[Karl Palmen]

Remove TubeCalibDemoMaps_Simple.py re #8263

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: e64d67e8c09fa9d129e542568c3bb4e7ff1e13ca

[Anders Markvardsen]

Merge remote-tracking branch 'origin/feature/8263_tube_calib_examples'

Full changeset: ​5f1b2288f9e8c83e43475fe56bbb29fd549aa848

[Anders Markvardsen]

scripts which have been superceded have been removed

[Stuart Campbell]

This ticket has been transferred to github issue ​9108