Ticket #8280 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

IntegratePeaksMD overlapping

Reported by: Owen Arnold Owned by: Vickie Lynch
Priority: critical Milestone: Release 3.1
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

We should try to do something to identify and warn against or prevent overlapping peak integration regions. This problem is particularly notable with the AdaptiveRadius option set to True in this algorithm.

A good mechanism for this might be, for each peak in the peaks workspace, look for a center-center distance that is less than either of their peak radius.

Change History

comment:1 Changed 7 years ago by Vickie Lynch

  • Status changed from new to inprogress

Refs #8280 warning for overlap

Changeset: ca0d69aaa831c9dd797b635fe06785a4f06ada2e

comment:2 Changed 7 years ago by Vickie Lynch

  • Status changed from inprogress to verify
  • Resolution set to fixed

Run script then increase radius for IntegratePeaksMD until warnings appear 

Load(Filename='/home/vel/systemtests/Data/WISH00016748.raw',OutputWorkspace='WISH00016748')
ConvertToDiffractionMDWorkspace(InputWorkspace='WISH00016748',OutputWorkspace='mdws',OneEventPerBin='0')
FindPeaksMD(InputWorkspace='mdws',MaxPeaks='10',OutputWorkspace='peaks')
IntegratePeaksMD(InputWorkspace='mdws',PeakRadius='0.02',BackgroundInnerRadius='0.024',BackgroundOuterRadius='0.029999999999999999',PeaksWorkspace='peaks',OutputWorkspace='integrated')

comment:3 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:4 Changed 7 years ago by Vickie Lynch

Refs #8280 Need factor of 2 for radius of both peaks

Changeset: f0961043d96dbce7116e250919c4d64af5301584

comment:5 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8280_overlapping_peaks'

Full changeset: ​1700786311d539783bc2ad64aece7f483e8cdce3

comment:6 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9125

Note: See TracTickets for help on using tickets.