Ticket #8292 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[IDA] ConvFit: Option to tie centres

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.1
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

ConvFit has a checkbox to optionally tie the centre of the lorentzians used for fitting when using two lorentzians. However currently it looks like the code simply defaults to using the ties, regardless of if the option is checked or not.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8292 Changed ConvFit to function created on the interface side.

Previously had two different functions creating the same fit function string.

Changeset: c038c44d2ea97546a69f4805efbfb4083f043f25

comment:2 Changed 7 years ago by Samuel Jackson

  • Component changed from Framework to Indirect Inelastic

comment:3 Changed 7 years ago by Samuel Jackson

Refs #8292 Make the use of ties optional.

Replace python side function building.

Changeset: b23d4c15afb62598a6a00365b767d67d5f46e473

comment:4 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester

Run through ConvFit using two Lorentzians with the tie centres option both checked and unchecked, look at the function string output in the results log and check that the ties are only added when the option is checked.

comment:5 Changed 7 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.1

comment:6 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:7 Changed 7 years ago by Martyn Gigg

Confirmed that the bug is only present when using a sequential fits in 3.0. A single run of the fit was working okay.

comment:8 Changed 7 years ago by Martyn Gigg

After the fix both single & sequential fits now perform as expected with respect to the tie option and produce the centres values that match each other.

comment:9 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8292_convfit_tie_centres'

Full changeset: ​559ad69602ac18ae91210536828ad7583150e005

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9137

Note: See TracTickets for help on using tickets.