Ticket #8334 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Use Start and End collection records for run status log filtering

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: critical Milestone: Release 3.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description

New START_COLLECTION and STOP_COLLECTION entries where added to the ISIS ICP_EVENT log 3 years ago. We can use these if present to get a more accurate run status for log filtering.

For the ICP_event log

  1. First check if There are START_COLLECTION and STOP_COLLECTION records present
  2. If not then process as before.
  3. If there are then process the running status purely from the START and STOP_COLLECTION records, not any of the other commands.
  4. Even though there is a Period number on the Start and Stop collection records DO NOT USE THIS, there is a rare situation where this would be wrong.
  5. Continue using the CHANGE_PERIOD records to create the period log as before.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Blocked By 8330 removed

(In #8330) Ticket #8334 created for follow on work

comment:2 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to inprogress

Re #8334. Removed unused constructor.

Changeset: 552bb530d9b80104fffe3d5c815b386f9861b8f4

comment:3 Changed 7 years ago by Roman Tolchenov

Re #8334. Added a new style parsing method to LogParser.

Changeset: d8c90c92ffc08f564fdff49a1b739e23b0fcb950

comment:4 Changed 7 years ago by Roman Tolchenov

Re #8334. Removed unused constructor.

Changeset: 532390652a971c7e8e3d15e6d8afe0810ab7061e

comment:5 Changed 7 years ago by Roman Tolchenov

Re #8334. Added a new style parsing method to LogParser.

Changeset: 242511b131ba9b95a3d11f12b250527499635418

comment:6 Changed 7 years ago by Roman Tolchenov

Re #8334. Fixing the tests and the redhat build.

Changeset: 00267876a9605017636133fc8575f49bf183fa87

comment:7 Changed 7 years ago by Roman Tolchenov

Re #8334. Redhat is still unhappy.

Changeset: 15ae377d45ca74944884d33f88ce5130d4ac86df

comment:8 Changed 7 years ago by Roman Tolchenov

Re #8334. Corrected the period changing.

Changeset: 95d8d5c050c9fe89a1172b539617e772626e0e61

comment:9 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester:

Check that 'running' and 'periods' logs get loaded correctly for both old and new styles of icp events.

comment:10 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:11 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8334_icp_event_log_changes'

Full changeset: ​49cfd481aedf997fa838c9a038853711da4721cc

comment:12 Changed 7 years ago by Gesner Passos

I've checked that it takes the new one if it is available and fall back to the old one otherwise.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9179

Note: See TracTickets for help on using tickets.