Ticket #8341 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

UnitTest SANS2D gui interaction

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: major Milestone: Release 3.1
Component: SANS Keywords:
Cc: peter.parker@… Blocked By:
Blocking: Tester: Peter Parker

Description

Although we do not have GUI unit tests, this ticket is to create a unit test that check that all the call and executions that SANS INTERFACE does through the ReductionSingleton() is available and correct.

It is implemented as unit test because it is fast, and will require just one file, that can be created on fly.

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

re #8341: SANS2D Gui Settings unit test

Changeset: 564ac091a4067872f9ad72889ece6080caff8889

comment:2 Changed 7 years ago by Gesner Passos

re #8341: add SANS2D Gui Settings unit to cmakelist

Changeset: f00c2baefd8ff880bdb6cc608ec5bbed955fd56c

comment:3 Changed 7 years ago by Gesner Passos

re #8341: add MaskFile for SANS2D Gui Settings unittest

Changeset: ca83a254996dd6432197cb3c5b86b0d72220bfca

comment:4 Changed 7 years ago by Gesner Passos

  • Cc peter.parker@… added
  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester:

These tests cover the usage of SANS Interface Settings tab. It ensures that all the executions and readings from that Tab responds as expected. Unfortunately, MaskFile command still requires a file as input. It would be great to have it accepting also "File, filename, or generator to read", these would allow us to remove the file loading part. I will add it as a new ticket #8406. But, to convince you to let this pass (it took 1.52 seconds to execute). The mean time for all the unit tests are 0.96 seconds with a standard deviation of 1.8. So, it is inside a good margin.

If you agree with me, and is convinced that the unit test provide good benefit (code review). Than, you may let it pass. (It has passed on all machines by now).

comment:5 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:6 Changed 7 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8341_sans_gui_unittest'

Full changeset: 03621162f71031fd7c4cca2cc948ec6cae3be22c

comment:7 Changed 7 years ago by Peter Parker

Looks good. Your stats have convinced me - it is fine being a unit test!

comment:8 Changed 5 years ago by Peter Parker

  • Blocking 8308 removed

(In #8308) See updated ticket description, and ignore previous comment from Gesner.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9187

Note: See TracTickets for help on using tickets.