Ticket #8343 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[C2E] Diagnostics tab: Division error min and max spectra

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.1
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: #8344 Tester: Gesner Passos

Description

We get a division error when anything other than the using both min and max spectra. This is probably just a range indexing thing.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Summary changed from [C2E] Diagnostics tab: Division errormin and max spectra to [C2E] Diagnostics tab: Division error min and max spectra

comment:2 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8343 Fixed error and refactored code.

Also modified the interface code to only allow the user to input a valid min/max value.

Changeset: 7a2cc3f603bfd19cda0de7b74f5606ba9e3f0616

comment:3 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

I've changed this so that the user shouldn't be able to enter an incorrect value and ensured that the calibration file gets loaded with the correct spectra range.

To Tester

Check that changing the upper and lower limits of the spectra in the diagnostics tab on the indirect C2E interface now works when using a calibration file and anything other than the default min/max values. Check that setting the min higher than the max gives an appropriate error message.

comment:4 Changed 7 years ago by Russell Taylor

  • Status changed from verify to reopened
  • Resolution fixed deleted

It looks to be this change that has changed the results of IRISDiagnostic & OSIRISDiagnostic system tests - please check.

comment:5 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to inprogress

Refs #8343 Fix for system test

Changeset: f1f8405184d632014dbe969e83924f0b943f99fa

comment:6 Changed 7 years ago by Samuel Jackson

Refs #8343 Rewritten slice functions to account for monitors.

Changeset: 0f021171d92c0400830ad66923903daca9fce174

comment:7 Changed 7 years ago by Samuel Jackson

  • Blocking 8344 added

comment:8 Changed 7 years ago by Samuel Jackson

I've re-written the code under this tab to take into account the monitors for an instrument when using a calibration file. Part of the problem was that not only were we potentially trying to use indices that were outside the size of the calibration file, but also because we were working with an uncropped raw file and a cropped calibration file.

To Test: As above

comment:9 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Milestone changed from Backlog to Release 3.1

comment:10 Changed 7 years ago by Samuel Jackson

  • Priority changed from critical to major

This shouldn't really be marked as critical. The bug was present in earlier releases of Mantid.

comment:11 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:12 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8343_c2e_diag_tab_spectrum_error'

Full changeset: ​b876a6b2e415ef5f3e7196470c6ce7874f2efdef

comment:13 Changed 7 years ago by Gesner Passos

You do get sensible results and error identification.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9188

Note: See TracTickets for help on using tickets.