[Muon] Move Settings tab

[Arturs Bekasovs]

From Stephen Cottrell:

I’ve been meaning to ask for a while to move the ‘settings’ tab to appear as the right most tab since the natural workflow is ‘Load’ -> ‘Group’ -> ‘Data Analysis’ -> ‘Results’, with the adjustment of ‘Settings’ being an exception.

[Arturs Bekasovs]

Refs #8348. Moved Settings tab in Qt Designer.

Changeset: b96eb2251ea706202f9634f5953649d2421d82d7

[Arturs Bekasovs]

Refs #8348. Use actual tab widget instead of numbers.

This makes the code independent from the order of tabs.

Changeset: 0d954dfe4cdc077b28a4ae3c28e7b85fd80c6799

[Arturs Bekasovs]

Tester:

Well, please check that Settings tab is the right-most in the tab-selector. :-)

Apart from that, I had to change the way we determine what tab the user is currently on. This influences a couple of things, so please verify the following:

• Auto-update is functional. No need to check every possible auto-updated field, just make sure you check at least one on every tab.

• If you haven't fitted any data and go to Results Table tab, an appropriate error message should be shown.

• Peak-Picker tool works correctly when on Data Analysis tab. It gets assigned to the current plot when you switch to the tab, it uses the correct Fit Property browser and it gets removed when you leave the tab.

[Samuel Jackson]

Merge remote-tracking branch 'origin/feature/8348_muon_move_settings_tab'

Full changeset: ​8f6ecde65de427aae7453dc7d37f1ca1777e5dd0

[Samuel Jackson]

Tab has been moved and the things you suggested to check appear to all be working.

[Stuart Campbell]

This ticket has been transferred to github issue ​9193